Feature/logger jar #874
Merged
Feature/logger jar #874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansible/README.md
Outdated
There was a problem hiding this comment.
I think this line in the README should change from a tomcat_deploy to an exec_jar
matthewandrews
approved these changes
Mar 19, 2025
sbearcsiro
requested changes
Mar 21, 2025
| @@ -6,7 +6,7 @@ | |||
| <conversionRule conversionWord="wex" converterClass="org.springframework.boot.logging.logback.WhitespaceThrowableProxyConverter" /> | |||
|
|
|||
| <variable name="appName" value="logger-service"/> | |||
| <variable name="LOG_DIR" value="/var/log/{{ tomcat | default('tomcat9')}}" /> | |||
| <variable name="LOG_DIR" value="{{ jar_log_path | default('/var/log/tomcat9')}}" /> | |||
There was a problem hiding this comment.
IMHO this should retain the tomcat version in the log path for the default case.
ie {{ jar_log_path | default('/var/log/' + tomcat)}} or however you'd express that in ansible
sbearcsiro
approved these changes
Mar 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.