Skip to content

Commit a590e38

Browse files
committed
#361 Commented why empty myAnnotation was sent
1 parent d3170cf commit a590e38

File tree

2 files changed

+4
-3
lines changed

2 files changed

+4
-3
lines changed

grails-app/services/au/org/ala/alerts/DiffService.groovy

+1-1
Original file line numberDiff line numberDiff line change
@@ -223,7 +223,7 @@ class DiffService {
223223
log.warn "queryId: " + queryResult.query.id + ", queryResult:" + queryResult.id + " last or previous objects contains HTML and not JSON"
224224
}
225225
} catch (Exception ex) {
226-
log.error("queryId: ${queryResult.query.id}, JsonPath error: ${ex}")
226+
log.error("queryId: ${queryResult.query.id}, Runtime error: ${ex.getMessage()}")
227227
}
228228

229229
return records

grails-app/services/au/org/ala/alerts/NotificationService.groovy

+3-2
Original file line numberDiff line numberDiff line change
@@ -117,7 +117,7 @@ class NotificationService {
117117
processedJson = processQuery(query, urlString)
118118
}
119119

120-
// todo:
120+
// todo: Legacy code.
121121
// Review: Duplicated with the process of identifying record changes after
122122
// It is only for updating the stored properties
123123
// Considering remove
@@ -129,7 +129,8 @@ class NotificationService {
129129
qr.previousResult = qr.lastResult
130130
qr.lastResult = qr.compress(processedJson)
131131
qr.lastChecked = checkDate
132-
//todo: review if it is necessary to store
132+
// todo: review if it fully supports all queries
133+
// Legacy code. It does not support MyAnnotation
133134
qr.hasChanged = diffService.hasChanged(qr)
134135
qr.queryUrlUsed = urlString
135136
qr.queryUrlUIUsed = urlStringForUI

0 commit comments

Comments
 (0)