Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PLEASE Don't MERGE #1672

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

PLEASE Don't MERGE #1672

wants to merge 4 commits into from

Conversation

temi
Copy link
Contributor

@temi temi commented Mar 4, 2025

  • supports new species list
  • added licence field for species list
  • migrated code to ECP and integrated them

@temi
#1586
b551c91 
- supports new species list
- added licence field for species list
- migrated code to ECP and integrated them
@temi temi requested a review from chrisala March 4, 2025 06:24
chrisala
chrisala approved these changes Mar 4, 2025
View reviewed changes
Copy link
Contributor

@chrisala chrisala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look fine but there will be an issue re: java17 - the ecodata-client-plugin dev branch (where the supporting changes are to be merged) is now java17 / ecodata-client-plugin:8.0.0-SNAPSHOT.

@temi
#1586
1f6b3d5 
- replaced postMultipart with OkHttp3 version
@temi temi changed the title #1586 PLEASE Don't MERGE Mar 6, 2025
temi added 2 commits March 6, 2025 12:10
@temi
#1586
4243d02 
- fixed missing service
@temi
#1586
4cfc922 
- added one more postMutipart method to WebService
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisala chrisala chrisala approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@temi @chrisala