Skip to content

Commit 9df9d92

Browse files
committed
minor cosmetic fixes
1 parent 9868523 commit 9df9d92

File tree

5 files changed

+9
-10
lines changed

5 files changed

+9
-10
lines changed

Diff for: .flake8

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
[flake8]
22
max-line-length = 120
3-
max-complexity = 19
3+
max-complexity = 20
44
select = C,E,F,W,B,B950
55
ignore = E126,E203,E501,W503,W504
66
exclude =

Diff for: src/dwcahandler/dwca/core_dwca.py

+3-3
Original file line numberDiff line numberDiff line change
@@ -188,10 +188,10 @@ def convert_values(v):
188188
files = zf.namelist()
189189

190190
log.info("Reading from %s", self.dwca_file_loc)
191-
#with zf.open(self.defaults_prop.meta_xml_filename) as meta_xml_file:
191+
192192
with io.TextIOWrapper(zf.open(self.defaults_prop.meta_xml_filename)) as meta_xml:
193-
self.meta_content.read_meta_file(meta_xml)
194-
meta_xml.close()
193+
self.meta_content.read_meta_file(meta_xml)
194+
meta_xml.close()
195195

196196
if self.meta_content.eml_xml_filename in files:
197197
with io.TextIOWrapper(zf.open(self.meta_content.eml_xml_filename),

Diff for: tests/__init__.py

+3-3
Original file line numberDiff line numberDiff line change
@@ -25,18 +25,18 @@ def make_fields(columns: list, term_uri: str):
2525
return fields
2626

2727

28-
def make_ext_str(ext_columns:list, term_uri: str):
28+
def make_ext_str(ext_columns: list, term_uri: str):
2929
ext_meta_str = ''
3030
fields = make_fields(ext_columns, term_uri)
3131
if fields:
32-
ext_meta_str = f'''
32+
ext_meta_str = f'''
3333
<extension encoding="UTF-8" rowType="http://rs.gbif.org/terms/1.0/Multimedia" fieldsTerminatedBy="," linesTerminatedBy="\\r\\n" fieldsEnclosedBy="&quot;" ignoreHeaderLines="1">
3434
<files>
3535
<location>multimedia.csv</location>
3636
</files>
3737
<coreid index="0"/>
3838
{fields}
39-
</extension>
39+
</extension>
4040
'''
4141
return ext_meta_str
4242

Diff for: tests/test_delete_dwca_content.py

-1
Original file line numberDiff line numberDiff line change
@@ -99,4 +99,3 @@ def test_delete_records_dwca_ext(self):
9999
pd.testing.assert_frame_equal(multimedia_df_output.drop(columns="coreid"), expected_mult_df)
100100

101101
zf.close()
102-

Diff for: tests/test_merge_dwca.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -74,8 +74,8 @@ def test_merge_core_and_ext_records(self):
7474
columns=['occurrenceID', 'scientificName', 'decimalLatitude', 'decimalLongitude'])
7575

7676
multimedia_df = pd.DataFrame(data=[["1", "https://image1.jpg", "image/jpeg", "StillImage"],
77-
["2", "https://image2.jpg", "image/jpeg", "StillImage"],
78-
["3", "https://image3.jpg", "image/jpeg", "StillImage"]],
77+
["2", "https://image2.jpg", "image/jpeg", "StillImage"],
78+
["3", "https://image3.jpg", "image/jpeg", "StillImage"]],
7979
columns=["occurrenceID", "identifier", "format", "type"])
8080

8181
dwca_ext_obj = make_dwca(occ_df, multimedia_df)

0 commit comments

Comments
 (0)