Use byte[] instead of stream #281

chrisala · chrisala · commit 26995efd5212 · 2025-03-13T07:51:01.000+11:00
diff --git a/grails-app/services/au/org/ala/ecodata/forms/EcpWebService.groovy b/grails-app/services/au/org/ala/ecodata/forms/EcpWebService.groovy
@@ -627,7 +627,10 @@ class EcpWebService {
                     responseData = objectMapper.readValue(responseData, Object)
                 }
             } else {
-                responseData = responseBody.byteStream()
+                // This is only used for the /document/createThumbnail endpoint.  Because the thumbnail is small we
+                // can get away with reading the entire response into memory.  If dealing with large files
+                // we might have to remove the try with resources and handle the stream manually.
+                responseData = responseBody.bytes()
             }
 
             result.statusCode = result.status = response.code()

Original file line number	Diff line number	Diff line change
`@@ -627,7 +627,10 @@ class EcpWebService {`
`627`	`627`	`responseData = objectMapper.readValue(responseData, Object)`
`628`	`628`	`}`
`629`	`629`	`} else {`
`630`		`- responseData = responseBody.byteStream()`
	`630`	`+ // This is only used for the /document/createThumbnail endpoint. Because the thumbnail is small we`
	`631`	`+ // can get away with reading the entire response into memory. If dealing with large files`
	`632`	`+ // we might have to remove the try with resources and handle the stream manually.`
	`633`	`+ responseData = responseBody.bytes()`
`631`	`634`	`}`
`632`	`635`
`633`	`636`	`result.statusCode = result.status = response.code()`