Functional tests for #177

Author: chrisala

grails-app/assets/javascripts/forms.js

@@ -772,7 +772,7 @@ function orEmptyArray(v) {
                                 if (_.isArray(val)) {
                                     selectedSoFar = selectedSoFar.concat(val);
                                 }
-                                else {
+                                else if (val != null) {
                                     selectedSoFar.push(val);
                                 }
                             });

grails-app/conf/example_models/constraintsExample.json

@@ -0,0 +1,108 @@
+{
+  "modelName": "Constraints example",
+  "dataModel": [
+    {
+      "dataType": "number",
+      "name": "number1"
+    },
+    {
+      "dataType": "text",
+      "name": "notes"
+    },
+    {
+      "dataType": "list",
+      "name": "list",
+      "columns": [
+        {
+          "name": "value1",
+          "dataType": "text"
+        },
+        {
+          "name": "nestedList",
+          "dataType": "list",
+          "columns": [
+            {
+              "name": "value2",
+              "dataType": "text",
+              "constraints": {
+                "type": "computed",
+                "excludePath": "list.nestedList.value2",
+                "default": [
+                  "c1",
+                  "c2",
+                  "c3",
+                  "c4"
+                ]
+              }
+            },
+            {
+              "name": "value3",
+              "dataType": "stringList",
+              "constraints": {
+                "type": "computed",
+                "includePath": "list.nestedList.value2",
+                "default": ["Default value"]
+              }
+            }
+          ]
+        }
+      ]
+    }
+  ],
+  "viewModel": [
+    {
+      "type": "row",
+      "items": [
+        {
+          "type": "number",
+          "source": "number1",
+          "preLabel": "number1"
+        }
+      ]
+    },
+    {
+      "type": "row",
+      "items": [
+        {
+          "type": "textarea",
+          "source": "notes",
+          "preLabel": "notes"
+        }
+      ]
+    },
+    {
+      "type": "repeat",
+      "source": "list",
+      "userAddedRows": true,
+      "items": [
+        {
+          "type": "row",
+          "items": [
+            {
+              "preLabel": "Value1",
+              "type": "selectOne",
+              "source": "value1"
+            }
+          ]
+        },
+        {
+          "type": "table",
+          "source": "nestedList",
+          "userAddedRows": true,
+          "columns": [
+            {
+              "type": "selectOne",
+              "title": "Value 2",
+              "source": "value2"
+            },
+            {
+              "type": "selectMany",
+              "title": "Value 3",
+              "source": "value3"
+            }
+          ]
+        }
+      ]
+    }
+  ]
+}

package-lock.json

@@ -15,7 +15,7 @@
     "@turf/convex": "^6.0.2",
     "@turf/length": "^6.0.2",
     "@turf/simplify": "^5.1.5",
-    "chromedriver": "108.0.0",
+    "chromedriver": "110.0.0",
     "geojson2svg": "^1.2.3",
     "handlebars": "^4.7.7",
     "jasmine-ajax": "^3.4.0",

package.json

@@ -0,0 +1,60 @@
+package au.org.ala.ecodata.forms
+
+import geb.module.Checkbox
+import geb.module.Select
+import geb.spock.GebReportingSpec
+import grails.testing.mixin.integration.Integration
+import pages.PreviewPage
+
+@Integration
+class ConstraintsSpec extends GebReportingSpec {
+
+    def "Constraints can be specified such that each constraint may be selected only once on a form"() {
+        when:
+        to ([name:'constraintsExample', data:'none'], PreviewPage)
+
+        then:
+        title == "Preview Constraints example"
+        page.model != null
+
+        when: "We first enter the page, the select configured as one value per form has all constraints available"
+        def selectValue2 = page.findFieldByModelName("value2").module(Select)
+
+        then:
+        selectValue2.find("option")*.value() == ['', 'c1', 'c2', 'c3', 'c4']
+
+        when: "We select a value from a value1 select"
+        selectValue2.selected = 'c2'
+        page.addTableRow("nestedList")
+        def value2List = page.findFieldByModelName("value2")
+
+        then: "that value should be unavailable for other instances of value1"
+        value2List[1].find("option")*.value() == ['', 'c1', 'c3', 'c4']
+
+    }
+
+    def "Constraints can be specified such that they take their values from selections of other fields "() {
+        when:
+        to ([name:'constraintsExample', data:'none'], PreviewPage)
+
+        then:
+        title == "Preview Constraints example"
+        page.model != null
+
+        when: "We first enter the page, the checkboxes configured to obtain options from value2 will have only the default"
+        def checkboxValue3 = $("[name=value3-0]").module(Checkbox)
+
+        then:
+        checkboxValue3.attr('value') == "Default value"
+        !checkboxValue3.checked
+
+        when: "We select something from value2"
+        def selectValue2 = page.findFieldByModelName("value2").module(Select)
+        selectValue2.selected = 'c3'
+
+        then: "That value becomes available for selection in our field"
+        def checkboxValue3Number2 = $("[name='value3-0']")
+        checkboxValue3Number2*.attr('value') == ['Default value', 'c3']
+
+    }
+}

src/integration-test/groovy/au/org/ala/ecodata/forms/ConstraintsSpec.groovy

@@ -97,4 +97,8 @@ class PreviewPage extends Page {
         }
     }
 
+    void addTableRow(String modelName) {
+        $("button[data-bind*='click:"+modelName+".addRow']").click()
+    }
+
 }