Merge pull request #284 from AtlasOfLivingAustralia/feature/biocollect-1586

fix an issue with old species list is not downloading the whole list but only the first 400

Author: chrisala

grails-app/services/au/org/ala/ecodata/forms/SpeciesListService.groovy

@@ -223,8 +223,8 @@ class SpeciesListService {
             return null
         }
 
-        String url = grailsApplication.config.getProperty('lists.baseURL') + SPECIES_LIST_ITEMS_PATH_V1 + '/' + listId
-        Map params = [includeKVP: true, pageSize: pageSize, page: page]
+        String url = grailsApplication.config.getProperty('lists.baseURL') + SPECIES_LIST_ITEMS_PATH_V1 + '/' + URLEncoder.encode(listId, ENCODING)
+        Map params = [includeKVP: true, offset: (page - 1) * page, max: pageSize]
         if (query) {
             params.q = query
         }

src/test/groovy/au/org/ala/ecodata/forms/SpeciesListServiceSpec.groovy

@@ -180,7 +180,7 @@ class SpeciesListServiceSpec extends Specification implements ServiceUnitTest<Sp
         def result = service.speciesListItemsUsingV1(listId, params.pageSize, params.page, params.q)
 
         then:
-        1 * webService.getJson({it.endsWith("/ws/speciesListItems/${listId}")}, params) >> mockResponse
+        1 * webService.getJson({it.endsWith("/ws/speciesListItems/${listId}")}, [includeKVP: true, max:10, offset: 0, q: "test"]) >> mockResponse
 
         and:
         if (expectedResult) {