Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tidy up model attributes for marking fields as readonly. #57

Open
chrisala opened this issue Feb 24, 2020 · 0 comments
Open

Tidy up model attributes for marking fields as readonly. #57

chrisala opened this issue Feb 24, 2020 · 0 comments

Comments

@chrisala
Copy link
Collaborator

chrisala commented Feb 24, 2020

Currently:

  • the view attribute "readonly" will result in the readonly attribute being applied to the rendered input field.
  • the view attribute "readOnly" will result in a field being rendered as a span, but only inside tables.
  • the view type "readonlyText" will result in a field being rendered as a span everywhere.
  • the view attribute "noEdit" will result in the view renderer being used for the field, even in edit mode.

Suggest the "readOnly" attribute be deprecated in favour of either "readonlyText" or "noEdit" to reduce confusion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant