On demand image thumbnails and tiles #214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbearcsiro
force-pushed
the
feature/on-demand-image-artefacts
branch
from
60f42ed to
4b47d89
Compare
sbearcsiro
force-pushed
the
feature/on-demand-image-artefacts
branch
from
4b47d89 to
2765d90
Compare
sbearcsiro
force-pushed
the
feature/on-demand-image-artefacts
branch
from
2765d90 to
a0c2da6
Compare
|
TODO before merging - image-utils needs to have 1.10 finalised |
- Split file operation code from GORM StorageLocation entities into separate StorageOperations classes - Replace filesize, redirect location, inputstream, mimetype, extension closures in ImageController with ImageInfo class to consolidate calls to S3, etc - Limit /image/$id/$type mappings to just known thumbnail types, fixes metadata fragments returning 404s - Make all AuditMessages save async - Add caching of ImageInfo objects for thumbnails and tiles - Add generating ImageThumbnail db entries when creating thumbnails - Add saving Image's maximum zoom level when creating tiles - Update commons-lang usage to commons-lang3 - Update gradle dependencies for postgres, zip4j, guava, caffeeine, google api client - Add Grails GORM Async entity support - Remove all use of LogService and replace with SLF4j
sbearcsiro
force-pushed
the
feature/on-demand-image-artefacts
branch
from
a0c2da6 to
98c47b2
Compare
- Remove unused ImageStoreService methods - Restore analyticsSerivce functionality - Fix ImageControllerSpec unit tests for new ImageController internals
sbearcsiro
force-pushed
the
feature/on-demand-image-artefacts
branch
from
7645ea2 to
eff47c3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses the root cause of #201 and #211, which is that the image thumbnail and tiling queue are ephemeral and don't survive an application restart.