Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix i18n issues #433

Closed
qifeng-bai opened this issue Feb 18, 2022 · 5 comments
Closed

Fix i18n issues #433

qifeng-bai opened this issue Feb 18, 2022 · 5 comments
Assignees

Comments

@qifeng-bai
Copy link
Contributor

qifeng-bai commented Feb 18, 2022

Tasks:

1, Use the default English messages if messages are not available for a target language
2, Switch languages based on locale

Link to PR created by @vjrj
#428 (review)

TEST:

https://spatial-test.ala.org.au/?lang=ES
https://spatial-test.ala.org.au/?lang=DE

@qifeng-bai qifeng-bai self-assigned this Feb 18, 2022
@vjrj
Copy link
Contributor

vjrj commented Feb 18, 2022

The PR is from Georg @biodivAtlasAT (Austria) thanks @qifeng-bai I was trying to review it only.

@qifeng-bai
Copy link
Contributor Author

@vjrj I have fixed up i18n issues and deployed on https://spatial-test.ala.org.au

You can switch languages by clicking the language button on the top left

@vjrj
Copy link
Contributor

vjrj commented Mar 3, 2022

Thanks indeed @qifeng-bai !

@biodivAtlasAT
Copy link

biodivAtlasAT commented Mar 3, 2022 via email

@patkyn
Copy link
Contributor

patkyn commented Apr 7, 2022

Tested and pass

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants