-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
We should re-enable liquibase or similar #213
Comments
Supporting the 'or similar' through database change statements in |
BTW liquibase also allows plain sql statements instead of a xml based changelogs, see: Some liquibase (or flyway) advantages to plan db changes:
|
Grails was supposed to track changes without the need to rely on liquibase or flyway. Unsure why that was not working. Liquibase prevented the application from starting in our production environment and playing with the configuration did not fix it. Auto track was not implemented into the build. Rollback would be nice if something goes wrong. All in all I spent less time to write these couple of lines of code than I had spent trying to work out why liquibase prevented the application from starting on our production. |
In grails to use an automatic database migration is not recommended, it's only for development purposes: If you point me to a branch and you show me the the couple of sql lines, I can help re-adding the liquibase support. |
Is there a workaround because liquibase prevents the application from starting in our production environment. The removal of liqubase fixed the problem. jstack was used to identify the issue as liquibase. I'm not inclined to test it in our production environment. |
I may have found the problem that was preventing the application from starting when using liquibase. I suspect it was an issue with an in-progress postgres backup. I will put this on hold until the postgres backup is updated, though this might take a while. |
Just for the record, for me, using Liquibase (or a similar tool) is as essential as using Git (or version control) in a project. If helps: About postgresql backups, I use |
- do not delete processed/<data-resource-id> directory so that we can obtain the pipeline jar log.
I see that liquibase was commented in:
https://github.com/AtlasOfLivingAustralia/spatial-service/releases/tag/1.1.2
If some new compatibility issue aroused, the plugin page in github gives some directions about which version we should use depending on grails and hibernate:
https://github.com/grails/grails-database-migration#versions
In the recent past this was not well documented and I suffer a bit to make it work with old versions of grails/hibernate/mysql-connector:
AtlasOfLivingAustralia/collectory#84 (comment)
In order to have a good maintenance of our dbs we should use some tool like liquibase or similar. For instance, disabling this, portals migrating directly to 1.1.2 will lose this db change:
https://github.com/AtlasOfLivingAustralia/spatial-service/blob/master/grails-app/migrations/changelog.xml
or similar.
cc @adam-collins
The text was updated successfully, but these errors were encountered: