Bump code style to PSR12 (#2)

* Bump code style to PSR12

* Add missing PSR12 reference

* Fix bcmul usage

* Remove docker certificates promotion

* Fix round usage

* Add more spaces

* Fix test float mapping

---------

Co-authored-by: Andrey Semikov <andrey.semikov@dealtrak.co.uk>

Author: GinoPane

.github/workflows/ci.yml

@@ -27,8 +27,7 @@ jobs:
         uses: php-actions/phpcs@v1
         with:
           php_version: 8.1
-          path: src/
-          standard: PSR2
+          standard: phpcs.xml
 
   tests:
     runs-on: ubuntu-latest

README.md

@@ -52,5 +52,5 @@ docker-compose run dynamodb-odm vendor/bin/behat -c behat.yml --stop-on-failure
 
 You need to check if the code style is OK by running:
 ```bash
-docker-compose run --no-deps dynamodb-odm vendor/bin/phpcs  --basepath=/application/src  --standard=PSR2 src
+docker-compose run --no-deps dynamodb-odm vendor/bin/phpcs --standard=/application/phpcs.xml
 ```

phpcs.xml

@@ -0,0 +1,37 @@
+<?xml version="1.0"?>
+<!-- @see https://pear.php.net/manual/en/package.php.php-codesniffer.annotated-ruleset.php -->
+<ruleset name= "PHPCS Rules">
+  <description>PHPCS ruleset for the DynamoDB ODM</description>
+
+  <file>src</file>
+
+  <!-- Show progress of the run -->
+  <arg value= "p"/>
+
+  <!-- Show sniff codes in all reports -->
+  <arg value= "s"/>
+
+  <!-- Ignore warnings -->
+  <arg value= "n"/>
+
+  <!-- Our base rule: set to PSR12 -->
+  <rule ref="PSR12" />
+
+  <rule ref= "Generic.Files.LineLength">
+    <properties>
+      <property name="lineLimit" value="80"/>
+      <property name="absoluteLineLimit" value="120"/>
+    </properties>
+  </rule>
+  <rule ref="PSR1.Methods.CamelCapsMethodName.NotCamelCaps">
+    <exclude-pattern>spec/</exclude-pattern>
+    <exclude-pattern>features/</exclude-pattern>
+  </rule>
+
+  <!-- All files MUST declare strict types. -->
+  <rule ref="Generic.PHP.RequireStrictTypes"/>
+
+  <rule ref="Generic.Files.LineEndings">
+    <exclude name="Generic.Files.LineEndings.InvalidEOLChar"/>
+  </rule>
+</ruleset>

spec/Repository/fixtures/NewModel.php

@@ -47,7 +47,7 @@ final class NewModel extends Model
     /**
      * @var float
      *
-     * @Types\NumberType
+     * @Types\FloatType
      */
     protected float $percent;
 

src/Annotation/AnnotationManager.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Autoprotect\DynamodbODM\Annotation;
 
 use Autoprotect\DynamodbODM\Annotation\Exception\NoPropertyFoundException;

src/Annotation/AnnotationManagerInterface.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Autoprotect\DynamodbODM\Annotation;
 
 use Autoprotect\DynamodbODM\Annotation\Property\PropertyInterface;

src/Annotation/Exception/AnnotationLogicException.php

@@ -8,5 +8,4 @@
 
 class AnnotationLogicException extends DynamoDbAdapterException
 {
-
 }

src/Annotation/Exception/DuplicatePrivatePropertyException.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Autoprotect\DynamodbODM\Annotation\Exception;
 
 use Autoprotect\DynamodbODM\Exception\DynamoDbAdapterException;

src/Annotation/Exception/EncryptionTypeNotSupportedException.php

@@ -8,5 +8,4 @@
 
 class EncryptionTypeNotSupportedException extends DynamoDbAdapterException
 {
-
 }

src/Annotation/Exception/NoEncryptionOptionsDefinedForProperty.php

@@ -2,7 +2,6 @@
 
 declare(strict_types=1);
 
-
 namespace Autoprotect\DynamodbODM\Annotation\Exception;
 
 use Autoprotect\DynamodbODM\Exception\DynamoDbAdapterException;

src/Annotation/Exception/NoTypeDefinedForPropertyException.php

@@ -8,5 +8,4 @@
 
 class NoTypeDefinedForPropertyException extends DynamoDbAdapterException
 {
-
 }

src/Annotation/Key/Primary.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Autoprotect\DynamodbODM\Annotation\Key;
 
 use Doctrine\Common\Annotations\Annotation;
@@ -19,5 +21,4 @@
 #[Attribute(Attribute::TARGET_PROPERTY)]
 class Primary
 {
-
 }

src/Annotation/Key/Sort.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Autoprotect\DynamodbODM\Annotation\Key;
 
 use Attribute;

src/Annotation/ModelAnnotationProcessor.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Autoprotect\DynamodbODM\Annotation;
 
 use Autoprotect\DynamodbODM\Annotation\Encryption\EncryptedPropertyInterface;
@@ -95,9 +97,11 @@ public function parseAnnotations(): void
             return;
         }
 
-        foreach ($this->getParentClassPrivateProperties(
-            $refClass->getParentClass()->getName()
-        ) as $parentProperty) {
+        foreach (
+            $this->getParentClassPrivateProperties(
+                $refClass->getParentClass()->getName()
+            ) as $parentProperty
+        ) {
             $annotationProperty = $this->buildAnnotationProperty($parentProperty);
 
             if (!is_null($annotationProperty)) {

src/Annotation/ModelAnnotationProcessorInterface.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Autoprotect\DynamodbODM\Annotation;
 
 use Autoprotect\DynamodbODM\Annotation\Property\AnnotationProperty;

src/Annotation/Types/BooleanType.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Autoprotect\DynamodbODM\Annotation\Types;
 
 use Attribute;

src/Annotation/Types/CollectionType.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Autoprotect\DynamodbODM\Annotation\Types;
 
 use Attribute;

src/Annotation/Types/DateType.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Autoprotect\DynamodbODM\Annotation\Types;
 
 use Attribute;

src/Annotation/Types/FloatType.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Autoprotect\DynamodbODM\Annotation\Types;
 
 use Attribute;

src/Annotation/Types/HashMapType.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Autoprotect\DynamodbODM\Annotation\Types;
 
 use Attribute;

src/Annotation/Types/IntegerType.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Autoprotect\DynamodbODM\Annotation\Types;
 
 use Attribute;

src/Annotation/Types/ModelType.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Autoprotect\DynamodbODM\Annotation\Types;
 
 use Attribute;

src/Annotation/Types/ModelTypeInterface.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Autoprotect\DynamodbODM\Annotation\Types;
 
 /**

src/Annotation/Types/Money.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Autoprotect\DynamodbODM\Annotation\Types;
 
 use Attribute;

src/Annotation/Types/MoneyType.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Autoprotect\DynamodbODM\Annotation\Types;
 
 use Attribute;

src/Annotation/Types/NumberType.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Autoprotect\DynamodbODM\Annotation\Types;
 
 use Attribute;

src/Annotation/Types/ScalarCollectionType.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Autoprotect\DynamodbODM\Annotation\Types;
 
 use Attribute;

src/Annotation/Types/StringType.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Autoprotect\DynamodbODM\Annotation\Types;
 
 use Attribute;

src/Annotation/Types/TypeInterface.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Autoprotect\DynamodbODM\Annotation\Types;
 
 /**

src/Client/DynamoDBPDOClient.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Autoprotect\DynamodbODM\Client;
 
 use Aws\DynamoDb\DynamoDbClient as DynamoDbClientSDK;

src/Client/DynamodbOperationsClient.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Autoprotect\DynamodbODM\Client;
 
 class DynamodbOperationsClient extends DynamoDBPDOClient implements DynamodbOperationsClientInterface

src/Client/DynamodbOperationsClientInterface.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Autoprotect\DynamodbODM\Client;
 
 interface DynamodbOperationsClientInterface

src/Client/PDOClientInterface.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Autoprotect\DynamodbODM\Client;
 
 use GuzzleHttp\Promise\PromiseInterface;

src/Factory/RepositoryFactory.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Autoprotect\DynamodbODM\Factory;
 
 use Aws\DynamoDb\Marshaler;
@@ -142,7 +144,7 @@ public function create(string $repositoryClassName, string $modelClassName): Dyn
      */
     private function createAnonymousRepository(string $modelClassName, Hydrator $hydrator): DynamoDBRepository
     {
-        return new class(
+        return new class (
             $modelClassName,
             $this->dynamodbOperationsClient,
             $this->queryBuilder,

src/Factory/RepositoryFactoryInterface.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Autoprotect\DynamodbODM\Factory;
 
 use Autoprotect\DynamodbODM\Repository\DynamoDBRepository;

src/Hydrator/AbstractHydrator.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Autoprotect\DynamodbODM\Hydrator;
 
 use DateTime;
@@ -176,7 +178,7 @@ protected function getModel(array $data, ?string $discriminatorFieldName = null)
     {
         $this->modelClassName = $this->getModelNameUsingParams($data, $discriminatorFieldName);
 
-        return new $this->modelClassName;
+        return new $this->modelClassName();
     }
 
     /**

src/Hydrator/Hydrator.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Autoprotect\DynamodbODM\Hydrator;
 
 use Autoprotect\DynamodbODM\Annotation\AnnotationManagerInterface;

src/Hydrator/HydratorInterface.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Autoprotect\DynamodbODM\Hydrator;
 
 use Autoprotect\DynamodbODM\Model\ModelInterface;

src/Hydrator/TypeHydrator/Date/DateTypeHydrator.php

@@ -10,7 +10,6 @@
 
 class DateTypeHydrator implements DateTypeHydratorInterface
 {
-
     public function hydrate(string $value): DateTimeInterface
     {
         try {

src/Hydrator/TypeHydrator/Enum/EnumTypeHydrator.php

@@ -78,15 +78,16 @@ protected function getEnumClassname(
         if (!$reflectionType instanceof ReflectionNamedType) {
             throw new PropertyShouldBeOfNamedTypeException(
                 sprintf(
-                    'Property %s should be ReflectionNamedType, '.
+                    'Property %s should be ReflectionNamedType, ' .
                     'e. g. should have only enum type in the class %s',
                     $annotationPropertyName,
                     $modelClassName
                 )
             );
         }
         $name = $reflectionType->getName();
-        if (!$reflectionType->allowsNull()
+        if (
+            !$reflectionType->allowsNull()
             &&
             !(
                 (