EMSUSD-2171 Fix multiple collection UI issues #4130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also addresses: EMSUSD-2168, EMSUSD-2169, EMSUSD-2171, EMSUSD-2167 Fix validation error: - Make the convertToCollectionString return the cause of any error. - Make the validator only handle the attribute error exception caused by the absence of expression support in old USD, not all exceptions. Fix list editor: - Replace ad-hoc code with QCompleter and QItemDelegate to edit the list items. - This fixes multiple interaction bugs. - Mark the filtered string list model items as being editable. - Make sure the list view gets focus after edit. - Make sure the new item can be added before deleting the old item in replaceStrings. - Simplify how the stage prims are gathered for suggestions.
pierrebai-adsk
added
bug
barbalt
previously approved these changes
Feb 21, 2025
|
So much simpler with qcompleter. Thank you |
pierrebai-adsk
added
the
ready-for-merge
pierrebai-adsk
removed
the
ready-for-merge
barbalt
approved these changes
Feb 21, 2025
pierrebai-adsk
added
the
ready-for-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also addresses: EMSUSD-2168, EMSUSD-2169, EMSUSD-2171, EMSUSD-2167, EMSUSD-2151
Fix validation error:
Fix list editor: