remove vestigial :error post hook calls

Author: vkarpov15

Diff for: lib/plugins/saveSubdocs.js

@@ -32,9 +32,7 @@ module.exports = function saveSubdocs(schema) {
         _this.$__.saveOptions.__subdocs = null;
       }
       if (error) {
-        return _this.$__schema.s.hooks.execPost('save:error', _this, [_this], { error: error }, function(error) {
-          next(error);
-        });
+        return next(error);
       }
       next();
     });
@@ -67,7 +65,6 @@ module.exports = function saveSubdocs(schema) {
       return;
     }
 
-    const _this = this;
     const subdocs = this.$getAllSubdocs({ useCache: true });
 
     if (!subdocs.length) {
@@ -86,17 +83,6 @@ module.exports = function saveSubdocs(schema) {
       }));
     }
 
-    try {
-      await Promise.all(promises);
-    } catch (error) {
-      await new Promise((resolve, reject) => {
-        this.$__schema.s.hooks.execPost('save:error', _this, [_this], { error: error }, function(error) {
-          if (error) {
-            return reject(error);
-          }
-          resolve();
-        });
-      });
-    }
+    await Promise.all(promises);
   }, null, unshift);
 };

Diff for: test/model.test.js

@@ -2154,17 +2154,23 @@ describe('Model', function() {
           next();
         });
 
+        let schemaPostSaveCalls = 0;
         const schema = new Schema({ name: String, child: [childSchema] });
         schema.pre('save', function(next) {
           this.name = 'parent';
           next();
         });
+        schema.post('save', function testSchemaPostSave(err, res, next) {
+          ++schemaPostSaveCalls;
+          next(err);
+        });
 
         const S = db.model('Test', schema);
         const s = new S({ name: 'a', child: [{ name: 'b', grand: [{ name: 'c' }] }] });
 
         const err = await s.save().then(() => null, err => err);
         assert.equal(err.message, 'Error 101');
+        assert.equal(schemaPostSaveCalls, 1);
       });
 
       describe('init', function() {