fix(document): handle virtuals that are stored as objects but getter returns string with toJSON #14468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…returns string with toJSON Fix #14446
hasezoey
reviewed
Mar 28, 2024
| })); | ||
|
|
||
| const child = await ChildModel.create({ name: { en: 'Stephen', de: 'Stefan' } }); | ||
| child.lang = 'en'; |
There was a problem hiding this comment.
from what i can tell lang is not actually part of the schema, is this required for this issue or should it be added?
There was a problem hiding this comment.
I think that's by design, it's meant to be a property that isn't saved to the db. Could make it into a virtual, but I don't think that's strictly necessary for this test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #14446
Summary
#14446 points out that we continue to loop through and try to create properties when getting nested paths underneath a virtual even if the virtual returned a non-object. Since this will always throw an error, we should just avoid that and assume this is just the virtual returning a non-object by design.
Examples