Recommendation list title improvements and remove current podcast (#4013)

Author: geekygecko

modules/features/discover/src/main/res/layout/row_podcast_large_list_with_podcast.xml

@@ -53,9 +53,9 @@
                 android:layout_width="wrap_content"
                 android:layout_height="wrap_content"
                 tools:text="The Daily"
-                style="@style/H20"
+                style="@style/H30"
                 android:includeFontPadding="false"
-                android:maxLines="2"
+                android:maxLines="1"
                 android:ellipsize="end"
                 android:textColor="?attr/primary_text_01"/>
 

modules/features/podcasts/src/main/java/au/com/shiftyjelly/pocketcasts/podcasts/viewmodel/podcast/RecommendationsHandler.kt

@@ -44,6 +44,7 @@ class RecommendationsHandler @Inject constructor(
                 if (enabled) {
                     getRecommendationsMaybe(podcastUuid)
                         .toFlowable()
+                        .removePodcast(podcastUuid)
                         .addSubscribedStatusFlowable()
                         .map { listFeed ->
                             if (listFeed.podcasts.isNullOrEmpty()) {
@@ -69,6 +70,13 @@ class RecommendationsHandler @Inject constructor(
         )
     }
 
+    private fun Flowable<ListFeed>.removePodcast(podcastUuid: String): Flowable<ListFeed> {
+        return map { list ->
+            val filteredPodcasts = list.podcasts?.filter { it.uuid != podcastUuid }
+            list.copy(podcasts = filteredPodcasts)
+        }
+    }
+
     private fun Flowable<ListFeed>.addSubscribedStatusFlowable(): Flowable<ListFeed> {
         return switchMap { list ->
             podcastManager.getSubscribedPodcastUuidsRxSingle()

modules/services/localization/src/main/java/au/com/shiftyjelly/pocketcasts/localization/helper/LocaliseHelper.kt

@@ -82,7 +82,7 @@ object LocaliseHelper {
         "popular in [regionname]" to R.string.discover_popular_in,
         "most popular in [category]" to R.string.discover_most_popular_in,
         "loved by listeners of" to R.string.recommendations_loved_by_listeners,
-        "if you like" to R.string.recommendations_if_you_like,
+        "because you like" to R.string.recommendations_because_you_like,
     )
 
     private val serverMessageIdToStringId = mapOf(

modules/services/localization/src/main/res/values/strings.xml

@@ -1793,7 +1793,7 @@
     <string name="discover_select_categories">Select a category</string>
     <string name="discover_show_all_categories">Show all categories</string>
     <string name="discover_dismiss_selected_category">Dismiss selected category</string>
-    <string name="recommendations_if_you_like">If you like</string>
+    <string name="recommendations_because_you_like">Because you like</string>
     <string name="recommendations_loved_by_listeners">Loved by listeners of</string>
     <string name="recommended_by_creator">Recommended shows by the creator</string>
     <string name="similar_shows_to">Shows similar to \"%s\"</string>