Skip to content

Skip recommendations when upselling from some features #3898

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 17, 2025
Merged

Skip recommendations when upselling from some features #3898

merged 2 commits into from
Apr 17, 2025

Conversation

MiSikora
Copy link
Contributor

Description

This PR removes podcasts recommendation step from the login flow when starting it from some of the paid features.

Fixes #3774

Testing Instructions

Verify that going through the upsell flow from these features doesn't offer you podcast recommendations:

  • Bookmarks
  • Preselect Chapters
  • Up Next Shuffle
  • Themes
  • Generated Transcripts

Checklist

  • If this is a user-facing change, I have added an entry in CHANGELOG.md
  • Ensure the linter passes (./gradlew spotlessApply to automatically apply formatting/linting)
  • I have considered whether it makes sense to add tests for my changes
  • All strings that need to be localized are in modules/services/localization/src/main/res/values/strings.xml
  • Any jetpack compose components I added or changed are covered by compose previews
  • I have updated (or requested that someone edit) the spreadsheet to reflect any new or changed analytics.`

@MiSikora MiSikora added [Type] Enhancement Improve an existing feature. [Area] Subscriptions Plus or Patron issue labels Apr 16, 2025
@MiSikora MiSikora added this to the 7.88 milestone Apr 16, 2025
@MiSikora MiSikora requested a review from a team as a code owner April 16, 2025 07:41
@MiSikora MiSikora requested review from geekygecko and removed request for a team April 16, 2025 07:41
@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Apr 16, 2025 •
edited
Loading

📲 You can test the changes from this Pull Request in 📱 Mobile by scanning the QR code below to install the corresponding build.
App Name 📱 Mobile
Build TypedebugProd
Commitca175d5
Direct Downloadpocketcasts-app-prototype-build-pr3898-ca175d5.apk
📲 You can test the changes from this Pull Request in 🚗 Automotive by scanning the QR code below to install the corresponding build.
App Name 🚗 Automotive
Build TypedebugProd
Commitca175d5
Direct Downloadpocketcasts-automotive-prototype-build-pr3898-ca175d5.apk
📲 You can test the changes from this Pull Request in ⌚ Wear by scanning the QR code below to install the corresponding build.
App Name ⌚ Wear
Build TypedebugProd
Commitca175d5
Direct Downloadpocketcasts-wear-prototype-build-pr3898-ca175d5.apk

geekygecko
geekygecko approved these changes Apr 17, 2025
View reviewed changes
Copy link
Member

@geekygecko geekygecko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test instructions mentioned themes but that didn't work for me and I still see the podcast recommendations.

features.mov

@MiSikora
Copy link
Contributor Author

Thanks for catching that. Fixed in ca175d5.

@MiSikora MiSikora enabled auto-merge (squash) April 17, 2025 09:42
@MiSikora MiSikora merged commit 181cd46 into main Apr 17, 2025
19 checks passed
@MiSikora MiSikora deleted the task/no-onboarding branch April 17, 2025 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geekygecko geekygecko geekygecko approved these changes

Assignees
No one assigned
Labels
[Area] Subscriptions Plus or Patron issue [Type] Enhancement Improve an existing feature.
Projects
None yet
Milestone
7.88
Development

Successfully merging this pull request may close these issues.

Consolidate account creation changes from Plus entry points
3 participants
@MiSikora @wpmobilebot @geekygecko