Temporary fix for video not playing in landscape mode #3823
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashiagr
added
[Type] Bug
📲 You can test the changes from this Pull Request in 📱 Mobile by scanning the QR code below to install the corresponding build.
📲 You can test the changes from this Pull Request in 🚗 Automotive by scanning the QR code below to install the corresponding build.
📲 You can test the changes from this Pull Request in ⌚ Wear by scanning the QR code below to install the corresponding build.
|
mebarbosa
approved these changes
Mar 28, 2025
ashiagr
added a commit
that referenced
this pull request
Mar 28, 2025
(cherry picked from commit f20d127)
10 tasks
ashiagr
added a commit
that referenced
this pull request
Mar 28, 2025
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This temporarily fixes video not playing in landscape mode issue.
It appears there was a race condition where the video view's surface was destroyed immediately after creation while transitioning from portrait to landscape mode. That caused the video to appear black or frozen.
I've added a small delay so that the surface is in a stable state before attachment. While it improves the behavior while transitioning between portrait and landscape mode, I've noticed that the picture-in-picture mode may still have the issue.
Partially fixes #3807
Testing Instructions
Screenshots or Screencast
before.webm
after.webm
Checklist
./gradlew spotlessApplyto automatically apply formatting/linting)modules/services/localization/src/main/res/values/strings.xmlI have tested any UI changes...