Skip to content

WIP add aria attributes to credit card error messages #103846

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: trunk
Choose a base branch
from

Conversation

gcsecsey
Copy link
Contributor

Fixes DOTCOM-13375 Make checkout form errors accessible to screen readers

Proposed Changes

This PR improves the accessibility of the credit card checkout form by ensuring that error messages are programmatically associated with their corresponding form fields and are announced by screen readers.

  • Refactored StripeErrorMessage Component:
    • Converted from a styled span to a styled div for improved semantics and flexibility.
    • Added aria-live="assertive" to ensure error messages are announced immediately by screen readers.
    • Added aria-invalid="true" to indicate the presence of an error.
    • The component now accepts an id prop, allowing it to be referenced by form fields via aria-describedby.
  • Accessibility Improvements:
    • Error messages are now programmatically associated with their respective input fields.
    • Screen readers will announce error messages as soon as they appear, improving the user experience for visually impaired users.

Why are these changes being made?

Testing Instructions

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

Copy link

github-actions bot commented May 30, 2025

@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • blaze-dashboard
  • help-center
  • notifications
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug dotcom-13375-make-checkout-form-errors-accessible-to-screen-readers on your sandbox.

@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~111 bytes added 📈 [gzipped])

name                     parsed_size           gzip_size
site-purchases                +109 B  (+0.0%)      +54 B  (+0.0%)
purchases                     +109 B  (+0.0%)      +54 B  (+0.0%)
checkout                      +109 B  (+0.0%)      +57 B  (+0.0%)
a8c-for-agencies-client       +109 B  (+0.0%)      +57 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants