Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Amazon clone #1064

Merged
merged 51 commits into from
Feb 1, 2025
Merged

Conversation

monark1
Copy link
Contributor

@monark1 monark1 commented Jan 27, 2025

Closes: #975

  • Title: Amazon Clone Contribution
  • Name: Monark Bhardwaj
  • Identify yourself: SWOC Contributor

Describe the add-ons or changes you've made 📃

I have developed a feature-rich Amazon Clone Project, which includes:

  • Home Page: A dynamic image slider and a clean display of featured products.
  • Product Page: Detailed product view with a thumbnail gallery, pricing, and description.
  • Cart Page: Interactive cart functionality with real-time total calculation and quantity adjustment.
  • Login Page: A secure and responsive login interface.
  • Responsive Design: Ensures compatibility across devices.
  • Dynamic JavaScript Functionalities: Automated slider

Screenshots 📷

Home Page

Home Page

Footer

Type of change ☑️

What sort of change have I made:

  • [] New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • This change requires a documentation update

Checklist: ☑️

  • [☑️] My code follows the Contributing Guidelines & Code of Conduct of this project.
  • [☑️] This PR does not contain plagiarized content.
  • [☑️] I have performed a self-review of my own code.
  • [☑️] I have commented my code, particularly wherever it was hard to understand.
  • [☑️] My changes generate no new warnings.

Note to reviewers 📄

This project is part of my open-source contribution under SWOC (Script Winter of Code). Please review the added functionality and provide feedback if necessary.

Copy link

vercel bot commented Jan 27, 2025

@monark1 is attempting to deploy a commit to the avdheshvarshney's projects Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

Thank you for submitting your pull request! We'll review it as soon as possible. For further communication, join our discord server https://discord.gg/tSqtvHUJzE.

@monark1
Copy link
Contributor Author

monark1 commented Jan 27, 2025

@Avdhesh-Varshney this time I have committed on remote branch

  • I have used JS for slider functionality, you can see it in script-header.js file

Copy link
Owner

@Avdhesh-Varshney Avdhesh-Varshney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Keep your project along with front-end projects.
  • Enlist it in json and readme files both.
  • Keep your images wrap up into a single folder named images. Don't mess up your project folder.
  • Keep 1 file named screenshot in webp format aside with index.html
  • Rename the entry point of the project with index.html

Do these changes in this pr, mention me!

@Avdhesh-Varshney Avdhesh-Varshney added bug Something isn't working Status: Requested Changes Warning: Follow Guidelines https://github.com/Avdhesh-Varshney/WebMasterLog/issues/108 labels Jan 27, 2025
@monark1
Copy link
Contributor Author

monark1 commented Jan 28, 2025

@Avdhesh-Varshney I have made all the requested changes,
Apologies for any inconvenience earlier, as I’m still learning to work with GitHub. Please review the updates and let me know if further changes are required.

Thank you for your patience!

Copy link
Owner

@Avdhesh-Varshney Avdhesh-Varshney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do one changes, Update your project folder name with only amazon.
Also do the necessary changes in readme enlisting and in data.json file.

As this project is already present in the same category. But I don't know why this issue still open.

@monark1
Copy link
Contributor Author

monark1 commented Jan 29, 2025

@Avdhesh-Varshney all changes done

@monark1
Copy link
Contributor Author

monark1 commented Jan 30, 2025

@Avdhesh-Varshney ??

1 similar comment
@monark1
Copy link
Contributor Author

monark1 commented Jan 30, 2025

@Avdhesh-Varshney ??

@Avdhesh-Varshney Avdhesh-Varshney added Status: Review Ongoing and removed bug Something isn't working Status: Requested Changes Warning: Follow Guidelines https://github.com/Avdhesh-Varshney/WebMasterLog/issues/108 labels Jan 31, 2025
@Avdhesh-Varshney Avdhesh-Varshney merged commit 9073539 into Avdhesh-Varshney:main Feb 1, 2025
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

📃: Amazon Clone
2 participants