Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PLT-26] User Authorization Login/Signup Page #1092

Merged
merged 4 commits into from
Mar 3, 2025
Merged

Conversation

Avdhesh-Varshney
Copy link
Owner

@Avdhesh-Varshney Avdhesh-Varshney commented Mar 1, 2025

Closes: #803

  • Issue Title: Setup User Authorization Pages
  • Your Name: Avdhesh Varshney
  • Your Role: Repo Owner

Describe the add-ons or changes you've made 📃

  • Setup routing of navbar with login and sign up pages
  • Update the styling of navbar & also code style (using Outlet feature of React Router Dom)
  • Add up sign up and login page with proper styling and responsiveness

Type of change ☑️

What sort of change have you made:

  • Bug fix
  • New feature
  • Code style update (formatting, local variables)
  • Documentation update
  • Database update

Copy link

UI - User Authentication

Copy link

vercel bot commented Mar 1, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
web-master-log ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 3, 2025 5:19am

@Avdhesh-Varshney Avdhesh-Varshney self-assigned this Mar 1, 2025
Copy link

github-actions bot commented Mar 1, 2025

Thank you for submitting your pull request! We'll review it as soon as possible. For further communication, join our discord server https://discord.gg/tSqtvHUJzE.

Copy link
Collaborator

@PayalKumari10 PayalKumari10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UserAuthForm.jsx file : Use === Instead of == for Type Comparisons

  • Replace all instances of == with === to ensure strict type checking and avoid unintended type coercion.
  • Similarly, use !== instead of !=.

@Avdhesh-Varshney Avdhesh-Varshney added the enhancement New feature or request label Mar 3, 2025
@Avdhesh-Varshney Avdhesh-Varshney merged commit 0f64bb9 into main Mar 3, 2025
2 checks passed
@Avdhesh-Varshney Avdhesh-Varshney deleted the feat/auth-ui branch March 3, 2025 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: done
Development

Successfully merging this pull request may close these issues.

📃: Complete User login/User signup Page✨
2 participants