Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added new JS project #155

Closed
wants to merge 1 commit into from
Closed

Conversation

anshulsoni4
Copy link

Pull Request for WebMasterLog 💡

Issue Title: #153 Web Music Player

  • Name of the project : Web music player
  • Category: Vanilla-JS-Projects
  • Name: Anshul Soni
  • GitHub ID: @anshulsoni4
  • Idenitfy yourself: GSSOC

Closes: #153

Describe the add-ons or changes you've made 📃

Added new JS project

Type of change ☑️

What sort of change have you made:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested? ⚙️

Checklist: ☑️

  • My code follows the Contributing Guidelines & Code of Conduct of this project.
  • This PR does not contain plagiarized content.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly wherever it was hard to understand.
  • My changes generate no new warnings.

Screenshots 📷

image

Note to reviewers 📄

pls review

Copy link

vercel bot commented May 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
web-master-log ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 17, 2024 1:17pm

@anshulsoni4
Copy link
Author

@Avdhesh-Varshney pls review

Copy link
Owner

@Avdhesh-Varshney Avdhesh-Varshney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@anshulsoni4 This PR can't be accepted. Because,

  1. You have committed in the main branch not create your own branch for this project.
  2. Audio files are very hugh in size which will increase the repository size. So, upload them either in your google drive and attach the shareable links in the code.
  3. Directory name is incorrect. It should be hyphen seprated as Music-App only.
  4. No readme file is present to explain the project.
  5. No screenshot is present as mentioned in contributing guidelines with proper example.

For further communication or any query, join the discord server https://discord.gg/tSqtvHUJzE

@Avdhesh-Varshney Avdhesh-Varshney added bug Something isn't working wontfix ❌ This will not be worked on labels May 18, 2024
@Avdhesh-Varshney Avdhesh-Varshney mentioned this pull request May 24, 2024
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working wontfix ❌ This will not be worked on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

📃: Web Music Player
2 participants