Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed navbar and also different branch #160

Closed
wants to merge 2 commits into from
Closed

Fixed navbar and also different branch #160

wants to merge 2 commits into from

Conversation

YadlaMani
Copy link
Contributor

Pull Request for WebMasterLog 💡

Issue Title: Adding a footer to the website

  • Name of the project :
  • Category:
  • Name:
  • GitHub ID:
  • Idenitfy yourself:

Closes:#142

Describe the add-ons or changes you've made 📃

Give a clear description of what have you added or modifications made
Added complete footer section
included social links,and repo links

Type of change ☑️

What sort of change have you made:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested? ⚙️

Checklist: ☑️

  • My code follows the Contributing Guidelines & Code of Conduct of this project.
  • This PR does not contain plagiarized content.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly wherever it was hard to understand.
  • My changes generate no new warnings.

Screenshots 📷

image

Note to reviewers 📄

Copy link

vercel bot commented May 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
web-master-log ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 18, 2024 11:34am

@YadlaMani
Copy link
Contributor Author

@Avdhesh-Varshney pls review this

Copy link
Owner

@Avdhesh-Varshney Avdhesh-Varshney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@YadlaMani These extra spaces removes and converting single quote into double quote is not required. Just add your code only.
And fill the PR template properly and linked your issue with it.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A lots of un-necessary changes not in this file but many other files.
Keep your tab size by default 4 not 2.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove these un-necessary changes done by you.

@YadlaMani
Copy link
Contributor Author

@Avdhesh-Varshney but it's the general convection of writing standard code right

@YadlaMani YadlaMani closed this by deleting the head repository May 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants