Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Pomodoro-Timer made using react.js #161

Closed

Conversation

VanshikaSabharwal
Copy link

@VanshikaSabharwal VanshikaSabharwal commented May 18, 2024

Pull Request for WebMasterLog 💡

Issue Title: Pomodoro-Timer made using react.js

  • Name of the project : Pomodor-Timer
  • Category: React.js
  • Name: Vanshika
  • GitHub ID: VanshikaSabharwal
  • Idenitfy yourself: GSSOC

Closes: #55

Describe the add-ons or changes you've made 📃

Give a clear description of what have you added or modifications made

I made a timer based on the pomodoro technique which is 25minute work and 5 minute rest. So, after every 25 minutes , there will be a 5 minute rest. The design is easy to use and user-friendly as well as responsive.

Type of change ☑️

What sort of change have you made:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested? ⚙️

I have used ESLint for linting and testing to verify there is no bug.

Checklist: ☑️

  • My code follows the Contributing Guidelines & Code of Conduct of this project.
  • This PR does not contain plagiarized content.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly wherever it was hard to understand.
  • My changes generate no new warnings.

Screenshots 📷

Screenshot 2024-05-12 194609
Screenshot 2024-05-12 194542

Copy link

vercel bot commented May 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
web-master-log ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 18, 2024 2:37pm

Copy link
Owner

@Avdhesh-Varshney Avdhesh-Varshney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@VanshikaSabharwal PR Not Approved
Same mistake again repeated as of last pr.

Copy link
Author

@VanshikaSabharwal VanshikaSabharwal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All files reviewed

Copy link
Owner

@Avdhesh-Varshney Avdhesh-Varshney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@VanshikaSabharwal leave this project, when you can't follow the guidelines properly.
This is too much to tell anyone again and again. This is not only waste of your time but my time also.

@Avdhesh-Varshney Avdhesh-Varshney added bug Something isn't working wontfix ❌ This will not be worked on and removed Requested Changes ⚙️ labels May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working wontfix ❌ This will not be worked on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

📃: Pomodoro Timer Website
2 participants