Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add-Url Scraper project under Node JS category #166

Merged

Conversation

Rags-Mishra
Copy link
Contributor

Pull Request for WebMasterLog 💡

Issue Title: URL Scraper using Node JS #49

  • Name of the project : Url-Scraper
  • Category: NodeJS
  • Name: Ragini Mishra
  • GitHub ID: Rags-Mishra #83007531
  • Idenitfy yourself: GSSOC'24 Contributer

Closes: #49

Describe the add-ons or changes you've made 📃

Give a clear description of what have you added or modifications made

Type of change ☑️

What sort of change have you made:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested? ⚙️

The folder is thoroughly tested across various websites which contain different kinds of data. The results were assuring the functionality of feature.

Checklist: ☑️

  • My code follows the Contributing Guidelines & Code of Conduct of this project.
  • This PR does not contain plagiarized content.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly wherever it was hard to understand.
  • My changes generate no new warnings.

Screenshots 📷

image
image

Note to reviewers 📄

Copy link

vercel bot commented May 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
web-master-log ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 2, 2024 9:22am

Copy link
Owner

@Avdhesh-Varshney Avdhesh-Varshney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Rags-Mishra you have neither read the guidelines nor read the main readme file.
Follow them properly. For further communication or doubt, join discord server https://discord.gg/tSqtvHUJzE

@Rags-Mishra
Copy link
Contributor Author

I missed including screenshot and update README.md file. I will certainly do so.

@Rags-Mishra
Copy link
Contributor Author

@Avdhesh-Varshney Kindly check the updates done.

Copy link
Owner

@Avdhesh-Varshney Avdhesh-Varshney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Rags-Mishra Resolve these changes.

Copy link

vercel bot commented May 30, 2024

@Rags-Mishra is attempting to deploy a commit to the avdheshvarshney's projects Team on Vercel.

A member of the Team first needs to authorize it.

@Rags-Mishra
Copy link
Contributor Author

Updates are done. Kindly check.

Copy link
Owner

@Avdhesh-Varshney Avdhesh-Varshney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Rags-Mishra One more changes, Keep your project inside the Intermediate directory.
As Node-JS-Projects/Intermediate/Url-Scraper Ok.
And update your project here also.

@Avdhesh-Varshney Avdhesh-Varshney removed the bug Something isn't working label May 31, 2024
@Rags-Mishra
Copy link
Contributor Author

Rags-Mishra commented May 31, 2024 via email

Copy link
Owner

@Avdhesh-Varshney Avdhesh-Varshney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Rags-Mishra PR Approved 🎉
But you have to update your project in the main readme file as mentioned.
But now leave it, i will do it.

@Avdhesh-Varshney Avdhesh-Varshney merged commit b2547b8 into Avdhesh-Varshney:main Jun 2, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

URL Scraper using Node JS
2 participants