feat: Barretenberg C++ binary overhaul #11459
Conversation
|
Merging master as boxes to get CI passing here |
| size_t required_crs_size = prover.proving_key->proving_key.circuit_size; | ||
| if constexpr (Flavor::HasZK) { | ||
| // Ensure there are enough points to commit to the libra polynomials required for zero-knowledge sumcheck | ||
| if (required_crs_size < curve::BN254::SUBGROUP_SIZE * 2) { |
There was a problem hiding this comment.
nit: I prefer required_crs_size = std::max(required_crs_size, curve::BN254::SUBGROUP_SIZE * 2);
There was a problem hiding this comment.
yeah this is nice, changed
| const std::filesystem::path& vk_path) override | ||
| { | ||
| const bool ipa_accumulation = flags.ipa_accumulation; | ||
| if (ipa_accumulation) { |
There was a problem hiding this comment.
not sure there is already a warning if multiple of these are set
There was a problem hiding this comment.
Right these should be made exclusive of each other
| @@ -51,6 +52,7 @@ inline std::vector<uint8_t> read_file(const std::string& filename, size_t bytes | |||
|
|
|||
| inline void write_file(const std::string& filename, std::vector<uint8_t> const& data) | |||
| { | |||
| info("writing file to ", filename); | |||
There was a problem hiding this comment.
Do we want this to stay in? maybe verbose only? I'm all for explicitness, but usually better to be like 'Writing proof to file ...' e.g. case by case
| } | ||
| functions_string = format(functions_string, "\n]}"); | ||
|
|
||
| const char* jsonData = functions_string.c_str(); |
There was a problem hiding this comment.
mind clearing up this nonsense (I know not yours) and just doing std::cout << functions_string;
| } | ||
|
|
||
| /** | ||
| * @brief Writes a sting to stdout | ||
| * | ||
| * @param str The raw string to write to stdout | ||
| */ | ||
| inline void writeStringToStdout(const std::string& str) | ||
| inline void write_string_to_stdout(const std::string& str) |
There was a problem hiding this comment.
can we just delete this and replace every use with std::cout << str;
There was a problem hiding this comment.
(answer can be no / in fast follow)
|
Great push overall, it's nice to see things with meaningful flags and not just esoteric combinations |
Co-authored-by: ludamad <adam.domurad@gmail.com>
codygunton
force-pushed
the
cg/uh-api
branch
from
b5d2d7b to
4289384
Compare
| @@ -40,7 +40,7 @@ for artifact in $artifacts_to_process; do | |||
|
|
|||
| echo "Generating verification key for function $fn_name" | |||
| # BB outputs the verification key to stdout as raw bytes, however, we need to base64 encode it before storing it in the artifact | |||
| verification_key=$($BB write_vk_for_ivc -b ${fn_artifact_path} -o - | base64) | |||
| verification_key=$($BB write_vk --scheme client_ivc -b ${fn_artifact_path} -o - | base64) | |||
There was a problem hiding this comment.
I guess this is immediately going to become confusing when we add a flow to write a CIVC VK. I wonder if this should just become the write_vk for mega honk..
There was a problem hiding this comment.
Yeah I thought about this but then it's the only mega honk command which seems weird. It think it makes sense to put it behind the --input_type flag in CIVC?
codygunton
added
e2e-all
Overhaul the Barretenberg binary and its API.
This could definitely use some more a help.
It was requested that the default change from UltraPlonk to UltraHonk, but we get rid of a default set of commands altogether. As a workaround, we can have users set
BB_SCHEME=ultra_honk.Newly created issues: AztecProtocol/barretenberg#1252, AztecProtocol/barretenberg#1253, AztecProtocol/barretenberg#1254, AztecProtocol/barretenberg#1255, AztecProtocol/barretenberg#1256, AztecProtocol/barretenberg#1257, AztecProtocol/barretenberg#1258, AztecProtocol/barretenberg#1259
Resolves AztecProtocol/barretenberg#1260
NB the line count is large because 1) CLI11 is a single 11k-line header; 2) I moved a lot of functions and some git mvs didn't show up as such. Main new code is api_ultra_honk.hpp.