Skip to content

Workaround for older model that doesnt specify required param #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 24, 2024

Conversation

pamelafox
Copy link
Contributor

Purpose

It appears that gpt-3.5-turbo 0613 doesn't specify required parameters as reliably as newer models, especially with other parameters being specified, which was breaking calls that involved filters. So this change means it will always default to the original user_query if no search_query was found in the parameters.

Does this introduce a breaking change?

When developers merge from main and run the server, azd up, or azd deploy, will this produce an error?
If you're not sure, try it out on an old environment.

[ ] Yes
[X] No

Type of change

[X] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

Code quality checklist

See CONTRIBUTING.md for more details.

:( no tests ye

@pamelafox pamelafox merged commit b66fb06 into main Jun 24, 2024
13 checks passed
@pamelafox pamelafox deleted the queryreq branch June 24, 2024 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant