Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CCP Connector for GoogleCloudPlatform DNS #11797

Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open

Conversation

v-pmalreddy
Copy link

Required items, please complete

Change(s):

  • Added new CCP Connector for GCP DNS

Reason for Change(s):

  • Due to deprecation of existing Azure Function app of GCP DNS

Version Updated:

  • Yes

Testing Completed:

  • Yes

Connector Status
Connector

@v-prasadboke v-prasadboke added Connector Connector specialty review needed and removed Codeless Connector Platform (CCP) Connector labels Feb 13, 2025
@v-pmalreddy
Copy link
Author

v-pmalreddy commented Feb 13, 2025 via email

@manishkumar1991
Copy link
Contributor

@v-pmalreddy

inside readme file , under section [Steps to add the new Collector]
when there is already a terraform script , automation for resource creations like sink , topic and subscription , why we are asking customer to check everything manual , why not to just run the terraform script and copy the output of script somewhere else , which will needed while configuring the data connector

And Why the topic name is same in DNS Connector,
the similar topic name is used in gcp firewall connector, kindly use the naming convention such that by reading topic name we can get an idea that it is for DNs connector ,
sentinel-dns-topic

@manishkumar1991
Copy link
Contributor

@v-pmalreddy I think, "GCPInitialAuthenticationSetup.tf" will be common for all GCP data connectors, then why it has been added in directory structure of terraform script, can't we use the existing one?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Connector Connector specialty review needed Content-Package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants