Workload Specific Compliance Update #1947
Open
+82
−82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arjenhuitema
requested changes
Mar 14, 2025
There was a problem hiding this comment.
@Springstone, thanks for making these changes. I left one comment on a toolTip, but this applies to multiple. Can you review and update the toolTip’s to align with the new label names?
| @@ -5406,21 +5406,21 @@ | |||
| "name": "enableWsCMKInitiatives", | |||
| "type": "Microsoft.Common.OptionsGroup", | |||
| "label": "Customer Managed Keys", | |||
| "defaultValue": "No", | |||
| "defaultValue": "Audit only", | |||
| "visible": true, | |||
| "toolTip": "If 'Yes' is selected you will have the option to selected management groups to apply Customer Managed Keys initiative to. This applies to all services that support CMK if enabled. Check initiative <a href=\"https://www.azadvertizer.net/azpolicyinitiativesadvertizer/Enforce-Encryption-CMK_20250218.html\">here</a>.", | |||
There was a problem hiding this comment.
Can you update the tool tip messages reflecting the change in name from Yes to Enforce or Audit only
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview/Summary
This pull request involves multiple changes to the
eslzArm/eslz-portal.jsonfile, primarily focused on updating the default values and labels for various policy initiatives to ensure better compliance tracking and enforcement.Key changes include:
Policy Descriptions:
Microsoft.Common.InfoBoxto provide clearer distinctions between "Enforce," "Audit only," and "Disabled" policies.Default Values and Labels:
defaultValuefor multiple policy initiatives from "No" to "Audit only" to ensure that non-compliant actions are logged by default. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13]allowedValueslabels for policy initiatives to "Enforce," "Audit only," and "Disabled" for better clarity and consistency. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13]Azure Public