Confirm before automatically setting a new environment as the default #4832
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Menghua1
requested review from
wbreza,
vhvb1989,
hemarina,
weikanglim and
JeffreyCA
as code owners
microsoft-github-policy-service
bot
added
the
no-recent-activity
|
Hi @@Menghua1. Thank you for your interest in helping to improve the Azure Developer CLI experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment. Otherwise, we'll close this out in 7 days. |
vhvb1989
reviewed
May 15, 2025
cli/azd/cmd/env.go
Outdated
Comment on lines
669
to
676
| if shouldSetDefault { | ||
| if err := en.azdCtx.SetProjectState(azdcontext.ProjectState{DefaultEnvironment: env.Name()}); err != nil { | ||
| return nil, fmt.Errorf("saving default environment: %w", err) | ||
| } | ||
| en.console.Message(ctx, | ||
| fmt.Sprintf( | ||
| "The new environment '%s' has been set as the default environment.", env.Name()), | ||
| ) |
There was a problem hiding this comment.
Can we add a message if !shouldSetDefault ? To display the name of the un-changed default environment?
Also, before asking about setting as default, check if there is at least one env already there. Because if this is the first environment created with azd env new , we should not ask and just set it as the default
There was a problem hiding this comment.
@vhvb1989 Thank you for your suggestion. Both the code and the PR description have been updated accordingly. Please review it.
cli/azd/pkg/environment/manager.go
Outdated
| if err := m.azdContext.SetProjectState(azdcontext.ProjectState{DefaultEnvironment: env.Name()}); err != nil { | ||
| return nil, fmt.Errorf("saving default environment: %w", err) | ||
| m.console.Message(ctx, "") | ||
| msg := fmt.Sprintf("Would you like to set the new environment '%s' as default environment?", env.Name()) |
There was a problem hiding this comment.
Same as before, check if the current default env name is different than env.Name() . If it is the same we don't want to ask and re-set the same env that is already the default env
There was a problem hiding this comment.
@vhvb1989 The code has been updated. Additionally, to clarify: the logic added in this PR is in the if isNew code block, which is only for new environments. If env.Name() is the same as the current default environment, it means that the environment already exists, the default environment will not change, and the part of the code I modified will not be executed.
…y un-changed default environment
Azure Dev CLI Install InstructionsInstall scriptsMacOS/Linux
bash: pwsh: WindowsPowerShell install MSI install Standalone Binary
MSI
Documentationlearn.microsoft.com documentationtitle: Azure Developer CLI reference
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue #4800.
Before setting a new environment as the default, we prompt the user to confirm whether to set it. If this is the first environment, it is set as the default without asking. As shown in the figure below:
azd env newcommand, the design is as follows:azd provision -e new-env, the design is as follows:@rajeshkamal5050 and @vhvb1989 for notification.