extension: support existing resource for ai build start
#5193
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hemarina
requested review from
wbreza,
vhvb1989,
weikanglim,
JeffreyCA and
rajeshkamal5050
as code owners
Azure Dev CLI Install InstructionsInstall scriptsMacOS/Linux
bash: pwsh: WindowsPowerShell install MSI install Standalone Binary
MSI
Documentationlearn.microsoft.com documentationtitle: Azure Developer CLI reference
|
vhvb1989
approved these changes
May 15, 2025
Comment on lines
+102
to
+104
| edisplay | ||
| eignore | ||
| eloading |
There was a problem hiding this comment.
Why do we need to add all of these new non-words?
There was a problem hiding this comment.
Added due to spell check error: https://github.com/Azure/azure-dev/actions/runs/15026950586/job/42229968592
wbreza
reviewed
May 16, 2025
Comment on lines
+102
to
+104
| edisplay | ||
| eignore | ||
| eloading |
There was a problem hiding this comment.
Why do we need to add all of these new non-words?
| @@ -69,6 +70,7 @@ message ComposedResource { | |||
| string type = 2; | |||
| bytes config = 3; | |||
| repeated string uses = 4; | |||
| string resource_id = 5; | |||
There was a problem hiding this comment.
Since the ComposedResource already contains a ResourceId, do we really need to modify the AddResourceRequest ?
Comment on lines
29
to
39
| func NewComposeService( | ||
| lazyAzdContext *lazy.Lazy[*azdcontext.AzdContext], | ||
| env *environment.Environment, | ||
| envManager environment.Manager, | ||
| ) azdext.ComposeServiceServer { | ||
| return &composeService{ | ||
| lazyAzdContext: lazyAzdContext, | ||
| env: env, | ||
| envManager: envManager, | ||
| } | ||
| } |
There was a problem hiding this comment.
We have to be careful adding non-lazy dependencies to the gRPC server side services because the component initialization can fail. For example, try running the command in a fold that doesn't have an azd project or environment yet and this will likely fail.
Take a look at some of the other gRPC services for examples to use lazy components.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #5103
