Adding support for input binding

Author: Swapnil Nagar

src/converters/toCoreFunctionMetadata.ts

@@ -1,12 +1,7 @@
 // Copyright (c) .NET Foundation. All rights reserved.
 // Licensed under the MIT License.
 
-import {
-    ExponentialBackoffRetryOptions,
-    FixedDelayRetryOptions,
-    GenericFunctionOptions,
-    SupportedDeferredBindingTypes,
-} from '@azure/functions';
+import { ExponentialBackoffRetryOptions, FixedDelayRetryOptions, GenericFunctionOptions } from '@azure/functions';
 import * as coreTypes from '@azure/functions-core';
 import { returnBindingKey } from '../constants';
 import { AzFuncSystemError } from '../errors';
@@ -24,7 +19,7 @@ export function toCoreFunctionMetadata(name: string, options: GenericFunctionOpt
         ...trigger,
         direction: 'in',
         type: isTrigger(trigger.type) ? trigger.type : trigger.type + 'Trigger',
-        properties: addDeferredBindingsFlag(options.trigger.type, options.trigger.deferredBindingType),
+        properties: addDeferredBindingsFlag(options.trigger?.deferredBinding),
     };
     bindingNames.push(trigger.name);
 
@@ -33,7 +28,7 @@ export function toCoreFunctionMetadata(name: string, options: GenericFunctionOpt
             bindings[input.name] = {
                 ...input,
                 direction: 'in',
-                //properties: addDeferredBindingsFlag(input.type),
+                properties: addDeferredBindingsFlag(input?.deferredBinding),
             };
             bindingNames.push(input.name);
         }
@@ -84,25 +79,11 @@ export function toCoreFunctionMetadata(name: string, options: GenericFunctionOpt
     return { name, bindings, retryOptions };
 }
 
-function addDeferredBindingsFlag(
-    triggerType: string,
-    deferredBindingType?: SupportedDeferredBindingTypes | unknown
-): { [key: string]: string } {
+function addDeferredBindingsFlag(deferredBindingType?: boolean | unknown): { [key: string]: string } {
     //Ensure that trigger type that is passed is valid and supported, to avoid customer misconfiguration.
-    console.log('Adding deferred binding flag: ', deferredBindingType);
-    //TODO there is inherent issue with converting the enum to string, look for fix in the when other SDK biniding will be supported.
-    const deferredBindingTypesSet = new Set<string>([
-        'blobTrigger',
-        //TODO: enum memeber conversion is running into error, issue is with the typescript.
-        //SupportedDeferredBindingTypes.BLOBTRIGGER,
-    ]);
-
-    if (
-        deferredBindingType !== undefined &&
-        deferredBindingType === triggerType &&
-        deferredBindingTypesSet.has(triggerType)
-    ) {
-        console.log('Adding deferred binding flag to trigger type:', triggerType);
+    console.log('Deferred binding flag value is: ', deferredBindingType);
+    if (deferredBindingType !== undefined && deferredBindingType === true) {
+        console.log('Adding deferred binding propertyu to trigger type:', deferredBindingType);
         return { supportsDeferredBinding: 'true' };
     }
 

src/deferred-binding/supportedDeferredBindingTypes.d.ts

@@ -1,10 +1,8 @@
 // Copyright (c) .NET Foundation. All rights reserved.
 // Licensed under the MIT License.
 
-import { SupportedDeferredBindingTypes } from '../src/deferred-binding/supportedDeferredBindingTypes';
 import { InvocationContext } from './InvocationContext';
 
-export * from '../src/deferred-binding/supportedDeferredBindingTypes';
 export * as app from './app';
 export * from './cosmosDB';
 export * from './cosmosDB.v3';
@@ -72,12 +70,6 @@ export interface FunctionOptions {
      * During invocation, set these values with `context.extraOutputs.set()`
      */
     extraOutputs?: FunctionOutput[];
-
-    /**
-     * Configuration for the optional deferredBindingTypey for this function
-     * This is the retry policy that will be used if the function fails during
-     */
-    deferredBindingType?: SupportedDeferredBindingTypes;
 }
 
 /**

types/index.d.ts

@@ -29,6 +29,11 @@ export interface StorageBlobOptions {
      * An app setting (or environment variable) with the storage connection string to be used by this blob input or output
      */
     connection: string;
+
+    /**
+     * Whether to use deferred binding for this blob operation.
+     * */
+    deferredBinding?: boolean;
 }
 
 export interface StorageQueueOptions {

types/storage.d.ts

@@ -11,12 +11,12 @@ export type StorageBlobClient = StorageBlobClientOptions;
 
 export interface StorageBlobClientOptions {
     /**
-     * Blob client to be used by this queue input or output. This is the client that will be used to perform operations on the blob storage.
+     * Blob client to be used by this blob input or output. This is the client that will be used to perform operations on the blob storage.
      */
     blobClient: BlobClient;
 
     /**
-     * Container client to be used by this queue input or output. This is the client that will be used to perform operations on the container storage.
+     * Container client to be used by this blob input or output. This is the client that will be used to perform operations on the container storage.
      */
     conatinerClient: ContainerClient;
 }