Skip to content

[TSV][Bug] Fix the missing configuration for current repo so it won't block normal customers #34211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
MaryGao opened this issue Apr 24, 2025 · 2 comments
Open

[TSV][Bug] Fix the missing configuration for current repo so it won't block normal customers #34211

MaryGao opened this issue Apr 24, 2025 · 2 comments

Comments

@MaryGao
Copy link
Member

MaryGao commented Apr 24, 2025 •
edited
Loading

SDK team is trying to add missing tspconfig.yaml for workloads/Workloads.SAPVirtualInstance.Management in our April release but we found the tsv checked all 4 libs under the same workloads folder. Since other 3 haven't have language configurations yet so we failed with TypeSpec Validation and the log is here.

Image

I think ultimately all spec should have configs but for now spec repos have some missing configurations libs, Could eng team have one-time fix for them?

Otherwise pr authors will be blocked by failures that is un-relevant to current services. Also I am curious why we include all libs under the same RP, any reasons to do that?
@MaryGao MaryGao changed the title [Discussion] Should tsv check all tspconfig.yaml under RP directory? [TSV][Discussion] Should tsv check all tspconfig.yaml under RP directory? Apr 24, 2025
@wanlwanl
Copy link
Member

Our goal is making all tspconfig are correct at the end.
I feel like after a while, when all/most of tspconfig are correct, it won't be a big issue.
But I'm not sure about what's the opinon of the TSV's owner. so cc @mikeharder

@MaryGao MaryGao changed the title [TSV][Discussion] Should tsv check all tspconfig.yaml under RP directory? [TSV][Discussion] Should tsv check all tspconfig.yaml under the same RP directory? Apr 24, 2025
@MaryGao MaryGao changed the title [TSV][Discussion] Should tsv check all tspconfig.yaml under the same RP directory? [TSV][Bug] Fix the missing configurations for current repo so it won't block normal customers Apr 24, 2025
@MaryGao MaryGao changed the title [TSV][Bug] Fix the missing configurations for current repo so it won't block normal customers [TSV][Bug] Fix the missing configuration for current repo so it won't block normal customers Apr 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@MaryGao @wanlwanl