Skip to content

[BUG] Microsoft.RecoveryServices/vaults updating softDeleteState does not work #34218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Klaas- opened this issue Apr 24, 2025 · 2 comments
Open
Labels
bug This issue requires a change to an existing behavior in the product in order to be resolved. customer-reported Issues that are reported by GitHub users external to the Azure organization. Mgmt This issue is related to a management-plane library. question The issue doesn't require a change to the product in order to be resolved. Most issues start as that RecoveryServices Service Attention Workflow: This issue is responsible by Azure service team.

Comments

@Klaas-
Copy link

Klaas- commented Apr 24, 2025

API Spec link

https://github.com/Azure/azure-rest-api-specs/blob/main/specification/recoveryservices/resource-manager/Microsoft.RecoveryServices/stable/2025-02-01/vaults.json

API Spec version

2025-02-01

Describe the bug

Hi,
it seems that updating the soft delete state does not work through the update process.

https://learn.microsoft.com/en-us/rest/api/recoveryservices/vaults/update?view=rest-recoveryservices-2025-02-01&tabs=HTTP&tryIt=true#code-try-0

PATCH https://management.azure.com/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.RecoveryServices/vaults/{vaultName}?api-version=2025-02-01

If I want to update the softDeleteState it does not actually change anything, even though I get a Response Code: 200

I can also see in the body of the response nothing has changed.

Expected behavior

Security Settings actually change

Actual behavior

Nothing, and no error

Reproduction Steps

use curl or https://learn.microsoft.com/en-us/rest/api/recoveryservices/vaults/update?view=rest-recoveryservices-2025-02-01&tabs=HTTP&tryIt=true#code-try-0

Post to a vault that does not have soft delete enabled:

{
    "properties": {
        "securitySettings": {
            "softDeleteSettings": {
                "softDeleteState": "Enabled"
            }
        }
    }
}

I've noticed this is a bigger bug during testing, actually more affected than just the setting I want to change:

{
    "properties": {
        "ERRORsecuritySettings": {
            "softDeleteSettings": {
                "softDeleteState": "Enabled"
            }
        }
    }
}

will error as it should but with no helpful message though

{
    "properties": {
        "securitySettings": {
            "THIS_SETTING_DOES_NOT_EXIST": "test",
            "softDeleteSettings": {
                "softDeleteState": "Enabled"
            }
        }
    }
}

Will happily report 200 back, but won't notice that the setting does not actually exist, so my guess is everything below securitySettings is broken.

Environment

current rhel8 curl and edge

@Klaas- Klaas- added the bug This issue requires a change to an existing behavior in the product in order to be resolved. label Apr 24, 2025
@microsoft-github-policy-service microsoft-github-policy-service bot added question The issue doesn't require a change to the product in order to be resolved. Most issues start as that customer-reported Issues that are reported by GitHub users external to the Azure organization. labels Apr 24, 2025
@v-jiaodi v-jiaodi added Service Attention Workflow: This issue is responsible by Azure service team. Mgmt This issue is related to a management-plane library. RecoveryServices labels Apr 28, 2025
@Klaas-
Copy link
Author

Klaas- commented May 6, 2025

It also does not work on create, same for MultiUserAuthorization

@Klaas-
Copy link
Author

Klaas- commented May 6, 2025

Create also has an undocumented required field: properties.publicNetworkAccess -- I am guessing you guys forgot to set a secure default?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue requires a change to an existing behavior in the product in order to be resolved. customer-reported Issues that are reported by GitHub users external to the Azure organization. Mgmt This issue is related to a management-plane library. question The issue doesn't require a change to the product in order to be resolved. Most issues start as that RecoveryServices Service Attention Workflow: This issue is responsible by Azure service team.
Projects
None yet
Development

No branches or pull requests

2 participants