Skip to content

Update mgmt template for JS #34550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 11, 2025
Merged

Update mgmt template for JS #34550

merged 2 commits into from
May 11, 2025

Conversation

v-jiaodi
Copy link
Member

@v-jiaodi v-jiaodi commented May 9, 2025

A minor fix for JS template to remove un-necessary option.

Copy link

openapi-pipeline-app bot commented May 9, 2025

Next Steps to Merge

✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge.

Copy link

openapi-pipeline-app bot commented May 9, 2025

PR validation pipeline restarted successfully. If there is ApiView generated, it will be updated in this comment.

@MaryGao MaryGao changed the title Update mgmt template Update mgmt template for JS May 9, 2025
@MaryGao MaryGao marked this pull request as ready for review May 9, 2025 03:55
Copy link

github-actions bot commented May 9, 2025

API Change Check

APIView identified API level changes in this PR and created the following API reviews

Language API Review for Package
Go sdk/resourcemanager/contoso/armcontoso
JavaScript @azure/arm-contoso

Copy link
Member

@raych1 raych1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please ensure this change is applied to the tsp init template too, thanks.

@maririos
Copy link
Member

maririos commented May 9, 2025

You also need to update:

@MaryGao
Copy link
Member

MaryGao commented May 11, 2025

There is no need for validation rule. @jiaodi Could you share prs to update tsp init template and js docs in sdk repo?

@MaryGao MaryGao merged commit 477d250 into Azure:main May 11, 2025
55 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
TypeSpec Authored with TypeSpec
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants