Skip to content

[Storage] Regenerate against v0.16.0, Fix ResultHeaders in TypeSpec #2702

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jun 17, 2025

Conversation

vincenttran-msft
Copy link
Member

@vincenttran-msft vincenttran-msft commented Jun 12, 2025

This PR does the following:

@github-actions github-actions bot added the Storage Storage Service (Queues, Blobs, Files) label Jun 12, 2025
Copy link

github-actions bot commented Jun 13, 2025

API Change Check

APIView identified API level changes in this PR and created the following API reviews

azure_storage_blob

@vincenttran-msft vincenttran-msft marked this pull request as ready for review June 17, 2025 00:05
@Copilot Copilot AI review requested due to automatic review settings June 17, 2025 00:05
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR regenerates the storage blob SDK against v0.16.0 of the TypeSpec toolchain and updates breaking changes from feature/blob-tsp, including fixing ResultHeaders signatures.

  • Updated client method signatures to include the new NoFormat generic in Response<T, NoFormat>.
  • Replaced AccessTier with AccessTierOptional and updated calls/test assertions accordingly.
  • Bumped TypeSpec dependency versions (tsp-location.yaml commit hash and emitter-package.json).

Reviewed Changes

Copilot reviewed 19 out of 20 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
sdk/storage/azure_storage_blob_test/src/lib.rs Added NoFormat import and updated create_test_blob return type
sdk/storage/azure_storage_blob/tsp-location.yaml Updated commit hash for feature/blob-tsp regeneration
sdk/storage/azure_storage_blob/tests/blob_client.rs Swapped AccessTier for AccessTierOptional and updated tests
sdk/storage/azure_storage_blob/src/lib.rs Export AccessTierOptional instead of AccessTier
sdk/storage/azure_storage_blob/src/clients/block_blob_client.rs Added NoFormat generic to commit/stage block methods
sdk/storage/azure_storage_blob/src/clients/blob_container_client.rs Added NoFormat generic to container client methods
sdk/storage/azure_storage_blob/src/clients/blob_client.rs Added NoFormat generic to blob client methods and updated tier param
eng/emitter-package.json Bumped TypeSpec-related dependencies to 0.16.x/1.1.x series
Files not reviewed (1)
  • eng/emitter-package-lock.json: Language not supported
Comments suppressed due to low confidence (1)

sdk/storage/azure_storage_blob/src/clients/block_blob_client.rs:109

  • Consider adding unit tests for commit_block_list (and stage_block) to validate the new Response<_, NoFormat> signature, ensuring that the client properly handles the response format change.
) -> Result<Response<BlockBlobClientCommitBlockListResult, NoFormat>> {

@vincenttran-msft vincenttran-msft merged commit bff964b into Azure:main Jun 17, 2025
24 checks passed
@vincenttran-msft vincenttran-msft deleted the vincenttran/v16 branch June 17, 2025 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Storage Storage Service (Queues, Blobs, Files)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants