Skip to content

[Feature] Add support for setting blob properties #869

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jun 28, 2022

Conversation

aaron-hardin
Copy link
Contributor

Adds an operation for set_properties
Set properties defined here: https://docs.microsoft.com/en-us/rest/api/storageservices/set-blob-properties

Related to #868

@ghost
Copy link

ghost commented Jun 28, 2022

CLA assistant check
All CLA requirements met.

Copy link
Contributor

@rylev rylev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍Thanks!

@rylev rylev requested a review from bmc-msft June 28, 2022 18:44
@bmc-msft
Copy link
Contributor

Thanks for the contribution! It looks like you're hitting conflict from a change that landed just a few minutes ago. #860.

Can you update this PR use the new HTTP types?

Copy link
Contributor

@bmc-msft bmc-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs updated types from #860, which just landed.

@aaron-hardin
Copy link
Contributor Author

Needs updated types from #860, which just landed.

👍 Thanks for the update

@bmc-msft
Copy link
Contributor

After changing the HTTP Verb to match the updated types, LGTM.

Again, thanks for the contributions!

@bmc-msft bmc-msft merged commit 9167ab5 into Azure:main Jun 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants