Fixed in code where using Splice inside foreach (#5869)

* fix splice

* Change files

* update

Author: carocao-msft

change-beta/@azure-communication-react-ae3c466a-72f6-405d-91d9-d0af847eca68.json

@@ -0,0 +1,9 @@
+{
+  "type": "patch",
+  "area": "fix",
+  "workstream": "Fixed in code where using splice inside foreach",
+  "comment": "Fixed in code where using splice inside foreach",
+  "packageName": "@azure/communication-react",
+  "email": "96077406+carocao-msft@users.noreply.github.com",
+  "dependentChangeType": "patch"
+}

change/@azure-communication-react-ae3c466a-72f6-405d-91d9-d0af847eca68.json

@@ -0,0 +1,9 @@
+{
+  "type": "patch",
+  "area": "fix",
+  "workstream": "Fixed in code where using splice inside foreach",
+  "comment": "Fixed in code where using splice inside foreach",
+  "packageName": "@azure/communication-react",
+  "email": "96077406+carocao-msft@users.noreply.github.com",
+  "dependentChangeType": "patch"
+}

packages/calling-stateful-client/src/CallContext.ts

@@ -1244,18 +1244,19 @@ export class CallContext {
     // if inProgressRealTimeTexts is an array
     if (inProgressRealTimeTexts && Array.isArray(inProgressRealTimeTexts)) {
       // find the in progress real time text that has not been updated for 5 seconds
-      inProgressRealTimeTexts.forEach((realTimeText, index) => {
-        if (realTimeText.updatedTimestamp && Date.now() - realTimeText.updatedTimestamp.getTime() > 5000) {
+      for (let i = inProgressRealTimeTexts.length - 1; i >= 0; i--) {
+        const realTimeText = inProgressRealTimeTexts[i];
+        if (realTimeText?.updatedTimestamp && Date.now() - realTimeText?.updatedTimestamp.getTime() > 5000) {
           // turn the in progress real time text to final
           realTimeText.resultType = 'Final';
           // move the in progress real time text to completed
           completedRealTimeTexts.push(realTimeText);
           // remove the in progress real time text from in progress
           if (inProgressRealTimeTexts) {
-            (inProgressRealTimeTexts as RealTimeTextInfo[]).splice(index, 1);
+            inProgressRealTimeTexts.splice(i, 1);
           }
         }
-      });
+      }
     } else {
       // if inProgressRealTimeTexts is a single object
       if (

packages/react-composites/src/composites/CallComposite/CallComposite.tsx

@@ -527,8 +527,10 @@ const MainScreen = (props: MainScreenProps): JSX.Element => {
 
   useEffect(() => {
     if (complianceNotification) {
-      activeNotifications.forEach((notification, index) => {
+      for (let i = activeNotifications.length - 1; i >= 0; i--) {
+        const notification = activeNotifications[i];
         if (
+          notification &&
           [
             'recordingStarted',
             'transcriptionStarted',
@@ -540,9 +542,9 @@ const MainScreen = (props: MainScreenProps): JSX.Element => {
             'transcriptionStoppedStillRecording'
           ].includes(notification.type)
         ) {
-          activeNotifications.splice(index, 1);
+          activeNotifications.splice(i, 1);
         }
-      });
+      }
       activeNotifications.push(complianceNotification);
     }
     setTrackedNotifications((prev) => updateTrackedNotificationsWithActiveNotifications(prev, activeNotifications));