NP-3239 clean up checkstyles and pmd.

Author: Eirik-Eide-Saur

cristin-import/src/main/java/no/unit/nva/cristin/lambda/CristinEntryEventConsumer.java

@@ -1,6 +1,5 @@
 package no.unit.nva.cristin.lambda;
 
-import static java.util.Objects.isNull;
 import static no.unit.nva.cristin.lambda.constants.HardcodedValues.HARDCODED_PUBLICATIONS_OWNER;
 import static no.unit.nva.publication.s3imports.ApplicationConstants.MAX_SLEEP_TIME;
 import static no.unit.nva.publication.s3imports.FileImportUtils.timestampToString;

cristin-import/src/main/java/no/unit/nva/cristin/mapper/CristinMapper.java

@@ -39,7 +39,6 @@
 import no.unit.nva.cristin.mapper.nva.NvaReportBuilder;
 import no.unit.nva.cristin.mapper.nva.exceptions.InvalidIsbnRuntimeException;
 import no.unit.nva.cristin.mapper.nva.exceptions.InvalidIssnRuntimeException;
-import no.unit.nva.cristin.mapper.nva.exceptions.InvalidUnconfirmedSeriesRuntimeException;
 import no.unit.nva.model.AdditionalIdentifier;
 import no.unit.nva.model.Contributor;
 import no.unit.nva.model.EntityDescription;
@@ -59,7 +58,6 @@
 import no.unit.nva.model.instancetypes.PublicationInstance;
 import no.unit.nva.model.pages.Pages;
 import no.unit.nva.publication.s3imports.UriWrapper;
-import nva.commons.core.attempt.Failure;
 import nva.commons.core.attempt.Try;
 import nva.commons.core.language.LanguageMapper;
 import nva.commons.doi.DoiConverter;
@@ -222,16 +220,13 @@ private Reference buildReference() {
     }
 
     private RuntimeException handlePublicationContextFailure(Exception exception) {
-        if(exception instanceof InvalidIssnException ) {
+        if (exception instanceof InvalidIssnException) {
             return new InvalidIssnRuntimeException(exception);
         }
-        if(exception instanceof InvalidIsbnException ) {
+        if (exception instanceof InvalidIsbnException) {
             return new InvalidIsbnRuntimeException(exception);
         }
-        if(exception instanceof InvalidUnconfirmedSeriesException ) {
-            return new InvalidUnconfirmedSeriesRuntimeException(exception);
-        }
-        if(exception instanceof RuntimeException ) {
+        if (exception instanceof RuntimeException) {
             return (RuntimeException) exception;
         }
         return new RuntimeException(exception);

cristin-import/src/main/java/no/unit/nva/cristin/mapper/CristinObject.java

@@ -15,11 +15,7 @@
 import lombok.AllArgsConstructor;
 import lombok.Builder;
 import lombok.Data;
-import no.unit.nva.cristin.mapper.nva.exceptions.InvalidUnconfirmedSeriesRuntimeException;
 import no.unit.nva.model.Publication;
-import no.unit.nva.model.exceptions.InvalidIsbnException;
-import no.unit.nva.model.exceptions.InvalidIssnException;
-import no.unit.nva.model.exceptions.InvalidUnconfirmedSeriesException;
 import nva.commons.core.JsonSerializable;
 
 @Data

cristin-import/src/main/java/no/unit/nva/cristin/mapper/nva/exceptions/InvalidIsbnRuntimeException.java

@@ -1,6 +1,6 @@
 package no.unit.nva.cristin.mapper.nva.exceptions;
 
-public class InvalidIsbnRuntimeException extends RuntimeException{
+public class InvalidIsbnRuntimeException extends RuntimeException {
 
     public InvalidIsbnRuntimeException(Exception cause) {
         super(cause);

cristin-import/src/main/java/no/unit/nva/cristin/mapper/nva/exceptions/InvalidIssnRuntimeException.java

@@ -1,6 +1,6 @@
 package no.unit.nva.cristin.mapper.nva.exceptions;
 
-public class InvalidIssnRuntimeException extends RuntimeException{
+public class InvalidIssnRuntimeException extends RuntimeException {
 
     public InvalidIssnRuntimeException(Exception cause) {
         super(cause);

cristin-import/src/main/java/no/unit/nva/cristin/mapper/nva/exceptions/InvalidUnconfirmedSeriesRuntimeException.java

@@ -290,7 +290,7 @@ public void handlerThrowsInvalidIsbnRuntimeExceptionWhenTheIsbnIsInvalid() throw
     }
 
     @Test
-    public void handlerThrowsInvalidIssnExceptionWhenTheIssnIsInvalid() throws JsonProcessingException {
+    public void handlerThrowsInvalidIssnRuntimeExceptionWhenTheIssnIsInvalid() throws JsonProcessingException {
         JsonNode cristinObjectWithInvalidIssn = CristinDataGenerator.objectWithInvalidIssn();
         AwsEventBridgeEvent<FileContentsEvent<JsonNode>> awsEvent =
                 CristinDataGenerator.toAwsEvent(cristinObjectWithInvalidIssn);