Skip to content

Commit 519648f

Browse files
Merge pull request #573 from BIBSYSDEV/update-commons-again
Update commons to 1.15.1
2 parents 651ec3f + 861f65c commit 519648f

File tree

3 files changed

+13
-12
lines changed

3 files changed

+13
-12
lines changed

gradle/libs.versions.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
[versions]
22

3-
nva = { strictly = '1.14.0' }
3+
nva = { strictly = '1.15.1' }
44
nvaDatamodel = { strictly = '0.14.0' }
55
jackson = { strictly = '2.12.4' }
66
awsSdk = { strictly = '1.12.52' }

publication-event-handlers/src/test/java/no/unit/nva/publication/events/doirequests/DoiRequestEventProducerTest.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@
2626
import no.unit.nva.model.Publication;
2727
import no.unit.nva.publication.doi.update.dto.PublicationHolder;
2828
import no.unit.nva.publication.events.DynamoEntryUpdateEvent;
29+
import no.unit.nva.publication.events.PublicationEventsConfig;
2930
import nva.commons.core.ioutils.IoUtils;
3031
import org.javers.core.Javers;
3132
import org.javers.core.JaversBuilder;
@@ -225,7 +226,7 @@ private void assertThatNewAndOldDifferOnlyInModifiedDate(Publication newPublicat
225226
@SuppressWarnings("unchecked")
226227
private AwsEventBridgeEvent<AwsEventBridgeDetail<DynamoEntryUpdateEvent>> parseEvent(String event) {
227228
EventParser<AwsEventBridgeDetail<DynamoEntryUpdateEvent>> eventEventParser =
228-
new EventParser<>(event);
229+
new EventParser<>(event, dynamoImageSerializerRemovingEmptyFields);
229230
return (AwsEventBridgeEvent<AwsEventBridgeDetail<DynamoEntryUpdateEvent>>)
230231
eventEventParser.parse(AwsEventBridgeDetail.class, DynamoEntryUpdateEvent.class);
231232
}

publication-rest/src/test/java/no/unit/nva/publication/create/CreatePublicationHandlerTest.java

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@
66
import static no.unit.nva.publication.testing.TestHeaders.getRequestHeaders;
77
import static no.unit.nva.publication.testing.TestHeaders.getResponseHeaders;
88
import static nva.commons.apigateway.ApiGatewayHandler.ALLOWED_ORIGIN_ENV;
9-
109
import static org.junit.jupiter.api.Assertions.assertEquals;
1110
import static org.junit.jupiter.api.Assertions.assertNotNull;
1211
import static org.mockito.ArgumentMatchers.any;
@@ -85,7 +84,8 @@ public void requestToHandlerReturnsCustomerCreated() throws Exception {
8584
GatewayResponse<PublicationResponse> expected = new GatewayResponse<>(
8685
PublicationMapper.convertValue(publication, PublicationResponse.class),
8786
getResponseHeadersWithLocation(publication.getIdentifier()),
88-
HttpStatus.SC_CREATED
87+
HttpStatus.SC_CREATED,
88+
restApiMapper
8989
);
9090

9191
assertEquals(expected, actual);
@@ -139,13 +139,13 @@ private Map<String, Map<String, Map<String, String>>> createRequestContext() {
139139

140140
private Publication createPublication() {
141141
return new Publication.Builder()
142-
.withIdentifier(new SortableIdentifier(UUID.randomUUID().toString()))
143-
.withModifiedDate(Instant.now())
144-
.withOwner("owner")
145-
.withPublisher(new Organization.Builder()
146-
.withId(URI.create("http://example.org/publisher/1"))
147-
.build()
148-
)
149-
.build();
142+
.withIdentifier(new SortableIdentifier(UUID.randomUUID().toString()))
143+
.withModifiedDate(Instant.now())
144+
.withOwner("owner")
145+
.withPublisher(new Organization.Builder()
146+
.withId(URI.create("http://example.org/publisher/1"))
147+
.build()
148+
)
149+
.build();
150150
}
151151
}

0 commit comments

Comments
 (0)