NP-3239 Remove 'Runtime' part from exception names.

Author: Eirik-Eide-Saur

cristin-import/src/main/java/no/unit/nva/cristin/mapper/AbstractPublicationInstanceBuilder.java

@@ -1,6 +1,6 @@
 package no.unit.nva.cristin.mapper;
 
-import no.unit.nva.cristin.mapper.nva.exceptions.UnsupportedSecondaryCategoryRuntimeException;
+import no.unit.nva.cristin.mapper.nva.exceptions.UnsupportedSecondaryCategoryException;
 import no.unit.nva.model.instancetypes.PublicationInstance;
 import no.unit.nva.model.pages.Pages;
 import nva.commons.core.JacocoGenerated;
@@ -22,8 +22,8 @@ public AbstractPublicationInstanceBuilder(CristinObject cristinObject) {
     public abstract PublicationInstance<? extends Pages> build();
 
     @JacocoGenerated
-    public UnsupportedSecondaryCategoryRuntimeException unknownSecondaryCategory() {
-        return new UnsupportedSecondaryCategoryRuntimeException(ERROR_PARSING_SECONDARY_CATEGORY);
+    public UnsupportedSecondaryCategoryException unknownSecondaryCategory() {
+        return new UnsupportedSecondaryCategoryException(ERROR_PARSING_SECONDARY_CATEGORY);
     }
 
     @JacocoGenerated

cristin-import/src/main/java/no/unit/nva/cristin/mapper/CristinContributorRoleCode.java

@@ -2,7 +2,7 @@
 
 import com.fasterxml.jackson.annotation.JsonCreator;
 import com.fasterxml.jackson.annotation.JsonValue;
-import no.unit.nva.cristin.mapper.nva.exceptions.UnsupportedRoleRuntimeException;
+import no.unit.nva.cristin.mapper.nva.exceptions.UnsupportedRoleException;
 
 import java.util.Arrays;
 
@@ -25,7 +25,7 @@ public static CristinContributorRoleCode fromString(String roleCode) {
         return Arrays.stream(CristinContributorRoleCode.values())
             .filter(role -> role.getStringValue().equalsIgnoreCase(roleCode))
             .findAny()
-            .orElseThrow(() -> new UnsupportedRoleRuntimeException(UNKNOWN_ROLE_ERROR + roleCode));
+            .orElseThrow(() -> new UnsupportedRoleException(UNKNOWN_ROLE_ERROR + roleCode));
     }
 
     @JsonValue

cristin-import/src/main/java/no/unit/nva/cristin/mapper/PublicationInstanceBuilderImpl.java

@@ -7,8 +7,8 @@
 import static no.unit.nva.cristin.mapper.CristinMainCategory.isReport;
 import java.util.Objects;
 
-import no.unit.nva.cristin.mapper.nva.exceptions.UnsupportedMainCategoryRuntimeException;
-import no.unit.nva.cristin.mapper.nva.exceptions.UnsupportedSecondaryCategoryRuntimeException;
+import no.unit.nva.cristin.mapper.nva.exceptions.UnsupportedMainCategoryException;
+import no.unit.nva.cristin.mapper.nva.exceptions.UnsupportedSecondaryCategoryException;
 import no.unit.nva.model.instancetypes.PublicationInstance;
 import no.unit.nva.model.pages.Pages;
 
@@ -39,9 +39,9 @@ public PublicationInstance<? extends Pages> build() {
         } else if (isEvent(cristinObject)) {
             return new EventBuilder(cristinObject).build();
         } else if (cristinObject.getMainCategory().isUnknownCategory()) {
-            throw new UnsupportedMainCategoryRuntimeException(ERROR_PARSING_MAIN_CATEGORY);
+            throw new UnsupportedMainCategoryException(ERROR_PARSING_MAIN_CATEGORY);
         } else if (cristinObject.getSecondaryCategory().isUnknownCategory()) {
-            throw new UnsupportedSecondaryCategoryRuntimeException(ERROR_PARSING_SECONDARY_CATEGORY);
+            throw new UnsupportedSecondaryCategoryException(ERROR_PARSING_SECONDARY_CATEGORY);
         }
         throw new RuntimeException(ERROR_PARSING_MAIN_OR_SECONDARY_CATEGORIES);
     }

cristin-import/src/main/java/no/unit/nva/cristin/mapper/nva/exceptions/UnsupportedMainCategoryException.java

@@ -0,0 +1,8 @@
+package no.unit.nva.cristin.mapper.nva.exceptions;
+
+public class UnsupportedMainCategoryException extends RuntimeException {
+
+    public UnsupportedMainCategoryException(String message) {
+        super(message);
+    }
+}

cristin-import/src/main/java/no/unit/nva/cristin/mapper/nva/exceptions/UnsupportedMainCategoryRuntimeException.java

@@ -0,0 +1,8 @@
+package no.unit.nva.cristin.mapper.nva.exceptions;
+
+public class UnsupportedRoleException extends RuntimeException {
+
+    public UnsupportedRoleException(String message) {
+        super(message);
+    }
+}

cristin-import/src/main/java/no/unit/nva/cristin/mapper/nva/exceptions/UnsupportedRoleException.java

@@ -0,0 +1,8 @@
+package no.unit.nva.cristin.mapper.nva.exceptions;
+
+public class UnsupportedSecondaryCategoryException extends RuntimeException {
+
+    public UnsupportedSecondaryCategoryException(String message) {
+        super(message);
+    }
+}

cristin-import/src/main/java/no/unit/nva/cristin/mapper/nva/exceptions/UnsupportedRoleRuntimeException.java

@@ -47,14 +47,11 @@
 import no.unit.nva.cristin.mapper.PublicationInstanceBuilderImpl;
 import no.unit.nva.cristin.mapper.nva.exceptions.InvalidIsbnRuntimeException;
 import no.unit.nva.cristin.mapper.nva.exceptions.InvalidIssnRuntimeException;
-import no.unit.nva.cristin.mapper.nva.exceptions.UnsupportedMainCategoryRuntimeException;
-import no.unit.nva.cristin.mapper.nva.exceptions.UnsupportedSecondaryCategoryRuntimeException;
+import no.unit.nva.cristin.mapper.nva.exceptions.UnsupportedMainCategoryException;
+import no.unit.nva.cristin.mapper.nva.exceptions.UnsupportedSecondaryCategoryException;
 import no.unit.nva.events.models.AwsEventBridgeEvent;
 import no.unit.nva.model.Publication;
 import no.unit.nva.model.PublicationStatus;
-import no.unit.nva.model.exceptions.InvalidIsbnException;
-import no.unit.nva.model.exceptions.InvalidIssnException;
-import no.unit.nva.model.exceptions.InvalidUnconfirmedSeriesException;
 import no.unit.nva.publication.s3imports.FileContentsEvent;
 import no.unit.nva.publication.s3imports.ImportResult;
 import no.unit.nva.publication.s3imports.UriWrapper;
@@ -213,7 +210,7 @@ public void handlerThrowsExceptionWhenMainCategoryTypeIsNotKnown() throws JsonPr
         RuntimeException exception = assertThrows(RuntimeException.class, action);
 
         Throwable cause = exception.getCause();
-        assertThat(cause, is(instanceOf(UnsupportedMainCategoryRuntimeException.class)));
+        assertThat(cause, is(instanceOf(UnsupportedMainCategoryException.class)));
         assertThat(cause.getMessage(), is(equalTo(PublicationInstanceBuilderImpl.ERROR_PARSING_MAIN_CATEGORY)));
     }
 
@@ -270,7 +267,7 @@ public void handlerThrowsExceptionWhenSecondaryCategoryTypeIsNotKnown() throws J
         RuntimeException exception = assertThrows(RuntimeException.class, action);
 
         Throwable cause = exception.getCause();
-        assertThat(cause, is(instanceOf(UnsupportedSecondaryCategoryRuntimeException.class)));
+        assertThat(cause, is(instanceOf(UnsupportedSecondaryCategoryException.class)));
         assertThat(cause.getMessage(), containsString(PublicationInstanceBuilderImpl.ERROR_PARSING_SECONDARY_CATEGORY));
 
     }