Python 3.13 Support, 3.8 EOL #787
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support for Python 3.13. Remove 3.8 because it is EOL as of Oct 2024. Bump to pybind11 2.13.0+, which add Python 3.13 support in CI.
ax3l
added
install
component: third party
EZoni
reviewed
Jan 8, 2025
There was a problem hiding this comment.
Is there a reason why we have 2.13.0 in one line and v2.13.6 in another line or is it just a typo?
There was a problem hiding this comment.
The one line is the minimum requirement for find_package (any newer than 2.13.0 will work), the other is the exact version we download on the fly (latest patch level, because great).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for Python 3.13.
Remove 3.8 because it is EOL as of Oct 2024.
Bump to pybind11 2.13.0+, which add Python 3.13 support in CI.
Same as:
Note that we remove Python 3.8 only from documentation for now, but do not hard enforce that it is not used (because old Ubuntu versions and CI still use it). Enforcement would go in
CMakeLists.txt(find_package(Python 3.9 ...)) and insetup.py(python_requires=">=3.8").