Skip to content

Possible missing code (build_features.py) #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
abhinab303 opened this issue Sep 27, 2020 · 2 comments
Open

Possible missing code (build_features.py) #15

abhinab303 opened this issue Sep 27, 2020 · 2 comments

Comments

@abhinab303
Copy link

image

build_features.py line 111:
Is this line trying to replace the original corpus? I think it does nothing now. This information is also used in function:
preprocess_corpus_notDropEntity

can I replace that line with this?
corpus[int(index2ind[int(ind)])] = corpus[int(index2ind[int(ind)])].replace(ori, ent)

@jimmy-walker
Copy link

Yes, it's so wired. How's your try?@abhinab303

@abhinab303
Copy link
Author

abhinab303 commented Nov 8, 2020

Yes, it's so wired. How's your try?@abhinab303

Hi there, sorry for late reply. We tried changing that line. But the difference is not much (1% change in f1 score). We are not getting good score for our dataset. Graph provided by the author works fine.

I have a simple question. For agnews dataset, do we use the title or the description for the "document"?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants