Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ring self shadowing #287

Merged
merged 1 commit into from
Feb 2, 2025
Merged

Fix ring self shadowing #287

merged 1 commit into from
Feb 2, 2025

Conversation

BarthPaleologue
Copy link
Owner

The ring shadow did not fade enough when you come too close to the ring.

Closes #256

@BarthPaleologue
Fix ring self shadowing
1dc4825 
The ring shadow fades out when you come too close to the ring
@BarthPaleologue BarthPaleologue linked an issue Feb 2, 2025 that may be closed by this pull request
Fix ring self-shadowing #256
Closed
nakul-py
nakul-py approved these changes Feb 2, 2025
View reviewed changes
Copy link
Contributor

@nakul-py nakul-py left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shadow will give more realistic image to the game.

@BarthPaleologue BarthPaleologue merged commit b6e5884 into main Feb 2, 2025
4 checks passed
@BarthPaleologue
Copy link
Owner Author

Yes shadows are very important! The next step will be to have shadows on planet surfaces and space stations as well 👌

@BarthPaleologue BarthPaleologue deleted the 256-fix-ring-self-shadowing branch February 2, 2025 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nakul-py nakul-py nakul-py approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix ring self-shadowing
2 participants
@BarthPaleologue @nakul-py