Improve spaceship automatic landing #305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't crash when the div is not present, rather inject it in the html directly
is the speed delta is small then we do nothing
It can land on landing pads!
we have to debloat this mess
this will avoid being stuck forever if it happens
it would no longer trigger when crossing rings => the type of TelluricPlanet was incorrect!
…transformable it is more flexible
This is useful for testing landing on surfaces
This should reduce occurences of clipping through objects because of ship controls
Courtesy of Claude 3.5 Sonnet. The test written are much better than what I would have done
If there are no results after raycasting, a special status is emitted and handled by the spaceship to cancel the landing
Now the subsequent flares are still visible, only the anamorphic and the central dot are hidden
This allows to move faster hotizontally while being careful vertically
this will allow for finer collisions hopefully
BarthPaleologue
force-pushed
the
227-improve-spaceship-automatic-landing
branch
from
2b10e47 to
a5415d4
Compare
This should prevent getting stuck in the station
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Tickets
Fixes #227
Description
The goal of this PR is to make spaceship landing more predictable by leveraging the physics engine in a cleaner way.
This is also an opportunity to extract this logic to a new component called the "Landing Computer".
The landing computer also unifies landing pad and surface landing procedures.
Unexpected difficulties
Torque is not mentionned in Havok, it is called angular impulse instead.
How to test
Try to land on any space station and on any planetary surface. Landing should either succeed or time out.
Known issue: when landing on planetary surfaces the spaceship wings can get stuck in the ground. A more durable solution will be needed, possibly by adding landing legs.
Follow-up
Further auto pilot can be implemented for NPCs in the future. And surface landing can still be improved.