expo: remove manual notification delegate in pre-build

Author: arnaud-roland

plugin/src/__tests__/withReactNativeBatchAppDelegate.test.ts

@@ -1,8 +1,5 @@
+import { appDelegateExpectedFixture, appDelegateFixture } from '../fixtures/appDelegate';
 import { modifyAppDelegate } from '../ios/withReactNativeBatchAppDelegate';
-import {
-  appDelegateExpectedFixture,
-  appDelegateFixture,
-} from '../fixtures/appDelegate';
 
 describe(modifyAppDelegate, () => {
   it('should modify the AppDelegate', () => {

plugin/src/fixtures/appDelegate.ts

@@ -157,8 +157,6 @@ static void InitializeFlipper(UIApplication *application) {
 
 export const appDelegateExpectedFixture = `#import "AppDelegate.h"
 
-#import <RNBatchPush/RNBatch.h>
-
 #if defined(EX_DEV_MENU_ENABLED)
 @import EXDevMenu;
 #endif
@@ -210,7 +208,6 @@ static void InitializeFlipper(UIApplication *application) {
 - (BOOL)application:(UIApplication *)application didFinishLaunchingWithOptions:(NSDictionary *)launchOptions
 {
   [RNBatch start];
-  [BatchUNUserNotificationCenterDelegate registerAsDelegate];
 
 #if defined(FB_SONARKIT_ENABLED) && __has_include(<FlipperKit/FlipperClient.h>)
   InitializeFlipper(application);

plugin/src/ios/withReactNativeBatchAppDelegate.ts

@@ -1,28 +1,20 @@
 import { ConfigPlugin, withAppDelegate } from '@expo/config-plugins';
-import { Props } from '../withReactNativeBatch';
 
 const DID_FINISH_LAUNCHING_WITH_OPTIONS_DECLARATION =
   '- (BOOL)application:(UIApplication *)application didFinishLaunchingWithOptions:(NSDictionary *)launchOptions\n{';
 
-const IMPORT_BATCH = '\n\n#import <RNBatchPush/RNBatch.h>\n';
-const REGISTER_BATCH = '\n  [RNBatch start];\n  [BatchUNUserNotificationCenterDelegate registerAsDelegate];\n';
+const REGISTER_BATCH = '\n  [RNBatch start];\n';
 
 export const modifyAppDelegate = (contents: string) => {
-  contents = contents.replace('\n', IMPORT_BATCH);
+  const [beforeDeclaration, afterDeclaration] = contents.split(DID_FINISH_LAUNCHING_WITH_OPTIONS_DECLARATION);
 
-  const [beforeDeclaration, afterDeclaration] = contents.split(
-    DID_FINISH_LAUNCHING_WITH_OPTIONS_DECLARATION
-  );
-
-  const newAfterDeclaration = DID_FINISH_LAUNCHING_WITH_OPTIONS_DECLARATION.concat(
-    REGISTER_BATCH
-  ).concat(afterDeclaration);
+  const newAfterDeclaration = DID_FINISH_LAUNCHING_WITH_OPTIONS_DECLARATION.concat(REGISTER_BATCH).concat(afterDeclaration);
 
   contents = beforeDeclaration.concat(newAfterDeclaration);
   return contents;
 };
 
-export const withReactNativeBatchAppDelegate: ConfigPlugin<{} | void> = config => {
+export const withReactNativeBatchAppDelegate: ConfigPlugin<object | void> = config => {
   return withAppDelegate(config, config => {
     config.modResults.contents = modifyAppDelegate(config.modResults.contents);
     return config;