profile: return promise from trackEvent to get errors in js side

Author: arnaud-roland

android/src/main/java/com/batch/batch_rn/RNBatchModule.java

@@ -733,9 +733,17 @@ public void profile_identify(String identifier) {
     }
 
     @ReactMethod
-    public void profile_trackEvent(String name, ReadableMap serializedEventData) {
+    public void profile_trackEvent(@NonNull String name, @Nullable ReadableMap serializedEventData, @NonNull Promise promise) {
         BatchEventAttributes attributes = RNUtils.convertSerializedEventDataToEventAttributes(serializedEventData);
+        if (attributes != null) {
+            List<String> errors = attributes.validateEventAttributes();
+            if (!errors.isEmpty()) {
+                promise.reject(BATCH_BRIDGE_ERROR_CODE, errors.toString());
+                return;
+            }
+        }
         Batch.Profile.trackEvent(name, attributes);
+        promise.resolve(null);
     }
 
     @ReactMethod

ios/RNBatch.m

@@ -406,7 +406,7 @@ -(void)stopObserving {
     [BatchProfile identify:identifier];
 }
 
-RCT_EXPORT_METHOD(profile_trackEvent:(NSString*)name data:(NSDictionary*)serializedEventData)
+RCT_EXPORT_METHOD(profile_trackEvent:(NSString*)name data:(NSDictionary*)serializedEventData resolver: (RCTPromiseResolveBlock)resolve rejecter:(RCTPromiseRejectBlock)reject)
 {
     BatchEventAttributes *batchEventAttributes = nil;
 
@@ -418,12 +418,14 @@ -(void)stopObserving {
         [batchEventAttributes validateWithError:&err];
         if (batchEventAttributes != nil && err == nil) {
             [BatchProfile trackEventWithName:name attributes:batchEventAttributes];
+            resolve([NSNull null]);
         } else {
-            NSLog(@"Event validation error: %@", err.description);
+            reject(@"BatchBridgeError", @"Event attributes validation failed:", err);
             return;
         }
     }
     [BatchProfile trackEventWithName:name attributes:batchEventAttributes];
+    resolve([NSNull null]);
 }
 
 - (BatchEventAttributes*) convertSerializedEventDataToEventAttributes:(NSDictionary *) serializedAttributes {

src/BatchProfile.ts

@@ -56,10 +56,10 @@ export const BatchProfile = {
    * @param name The event name. Must be a string.
    * @param data The event attributes (optional). Must be an object.
    */
-  trackEvent: (name: string, data?: BatchEventAttributes): void => {
+  trackEvent: (name: string, data?: BatchEventAttributes): Promise<void> => {
     // Since _toInternalRepresentation is private, we have to resort to this little hack to access the method.
     // That syntax keeps the argument type checking, while casting as any would not.
-    RNBatch.profile_trackEvent(name, data instanceof BatchEventAttributes ? data['_toInternalRepresentation']() : null);
+    return RNBatch.profile_trackEvent(name, data instanceof BatchEventAttributes ? data['_toInternalRepresentation']() : null);
   },
 
   /**