Skip to content

Commit b83e53d

Browse files
Remember last channel in .tt files for Android
Introduces <join-last-channel> in <join> section of .tt files.
1 parent 76f5038 commit b83e53d

File tree

4 files changed

+13
-6
lines changed

4 files changed

+13
-6
lines changed

ChangeLog.txt

+1
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@ Default Qt Client
2323
- Fixed language not set at first start
2424
- Fixed OPUS DTX mode sending too big packets when variable bitrate mode (VBR) was disabled
2525
Android Client
26+
- The "last joined channel" checkbox and nickname's value now saves on tt files up on export and loads up on impoart, so your settings for these options will no longer be lost!
2627
- Ability to export each server in to a .tt file separately
2728
- Broadcast messages are now shown in the chat tab
2829
- Added the ability to send broadcast messages

Client/TeamTalkAndroid/src/main/java/dk/bearware/gui/ServerEntryActivity.java

+3-3
Original file line numberDiff line numberDiff line change
@@ -122,12 +122,12 @@ protected void onPause() {
122122
@Override
123123
protected void onStart() {
124124
super.onStart();
125-
126-
if ((serverentry != null) && serverentry.rememberLastChannel) {
125+
126+
if (serverentry != null) {
127127
showServer(serverentry);
128128
serverentry = null;
129129
}
130-
130+
131131
// Bind to LocalService if not already
132132
if (mConnection == null)
133133
mConnection = new TeamTalkConnection(this);

Client/TeamTalkAndroid/src/main/java/dk/bearware/gui/ServerListActivity.java

+1-2
Original file line numberDiff line numberDiff line change
@@ -164,7 +164,7 @@ protected void onPause() {
164164
protected void onStart() {
165165
super.onStart();
166166

167-
if ((serverentry != null) && serverentry.rememberLastChannel) {
167+
if (serverentry != null) {
168168
saveServers();
169169
}
170170

@@ -275,7 +275,6 @@ protected void onActivityResult(int requestCode, int resultCode, Intent data) {
275275
if (entries != null) {
276276
for (ServerEntry entry : entries) {
277277
entry.servertype = ServerEntry.ServerType.LOCAL;
278-
entry.rememberLastChannel = true;
279278
}
280279
servers.addAll(entries);
281280
Collections.sort(servers, this);

Client/TeamTalkAndroid/src/main/java/dk/bearware/gui/Utils.java

+8-1
Original file line numberDiff line numberDiff line change
@@ -294,7 +294,6 @@ public static Vector<ServerEntry> getXmlServerEntries(String xml) {
294294
if (hostnode.getNodeType() == Node.ELEMENT_NODE) {
295295
Element hostelement = (Element) hostnode;
296296
ServerEntry entry = new ServerEntry();
297-
entry.rememberLastChannel = false;
298297
NodeList namenode = hostelement.getElementsByTagName("name");
299298
if (namenode.getLength() > 0)
300299
entry.servername = namenode.item(0).getTextContent();
@@ -361,6 +360,9 @@ public static Vector<ServerEntry> getXmlServerEntries(String xml) {
361360
NodeList passwordnode = authelement.getElementsByTagName("password");
362361
if (passwordnode.getLength() > 0)
363362
entry.password = passwordnode.item(0).getTextContent();
363+
NodeList nicknamenode = authelement.getElementsByTagName("nickname");
364+
if (nicknamenode.getLength() > 0)
365+
entry.nickname = nicknamenode.item(0).getTextContent();
364366
}
365367
}
366368
//process <join>
@@ -369,6 +371,9 @@ public static Vector<ServerEntry> getXmlServerEntries(String xml) {
369371
Node joinnode = joinlist.item(0);
370372
if (joinnode.getNodeType() == Node.ELEMENT_NODE) {
371373
Element joinelement = (Element) joinnode;
374+
NodeList joinlastchannelnode = hostelement.getElementsByTagName("join-last-channel");
375+
if (joinlastchannelnode.getLength() > 0)
376+
entry.rememberLastChannel = joinlastchannelnode.item(0).getTextContent().equalsIgnoreCase("true");
372377
NodeList channelnode = joinelement.getElementsByTagName("channel");
373378
if (channelnode.getLength() > 0)
374379
entry.channel = channelnode.item(0).getTextContent();
@@ -426,8 +431,10 @@ public static boolean saveServers(Vector<ServerEntry> servers, String path) {
426431
serializer.startTag(null, "auth");
427432
serializer.startTag(null, "username").text(server.username).endTag(null, "username");
428433
serializer.startTag(null, "password").text(server.password).endTag(null, "password");
434+
serializer.startTag(null, "nickname").text(server.nickname).endTag(null, "nickname");
429435
serializer.endTag(null, "auth");
430436
serializer.startTag(null, "join");
437+
serializer.startTag(null, "join-last-channel").text(String.valueOf(server.rememberLastChannel)).endTag(null, "join-last-channel");
431438
serializer.startTag(null, "channel").text(server.channel).endTag(null, "channel");
432439
serializer.startTag(null, "password").text(server.chanpasswd).endTag(null, "password");
433440
serializer.endTag(null, "join");

0 commit comments

Comments
 (0)