fix: Prevent multiple identical instantiations of application identity within calls to TestTrack.app_ab (#132)

* fix: Memoize identity within calls to TestTrack.app_ab

* Bump version

* Fix spec

* Use more concise identity logic and fix specs

Author: willlockwood

Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    test_track_rails_client (7.1.1)
+    test_track_rails_client (7.1.2)
       activejob (>= 6.0)
       activemodel (>= 6.0)
       faraday (>= 0.8)

app/models/test_track/application_identity.rb

@@ -12,7 +12,7 @@ def app_name
   end
 
   def identity
-    Identity.new(app_name)
+    @identity ||= Identity.new(app_name)
   end
 
   class Identity

gemfiles/rails_6_1.gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: ..
   specs:
-    test_track_rails_client (7.1.1)
+    test_track_rails_client (7.1.2)
       activejob (>= 6.0)
       activemodel (>= 6.0)
       faraday (>= 0.8)

gemfiles/rails_7_0.gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: ..
   specs:
-    test_track_rails_client (7.1.1)
+    test_track_rails_client (7.1.2)
       activejob (>= 6.0)
       activemodel (>= 6.0)
       faraday (>= 0.8)

lib/test_track_rails_client/version.rb

@@ -1,3 +1,3 @@
 module TestTrackRailsClient
-  VERSION = "7.1.1".freeze
+  VERSION = "7.1.2".freeze
 end

spec/rails_helper.rb

@@ -56,5 +56,7 @@
   config.before(:each) do
     clear_enqueued_jobs
     clear_performed_jobs
+
+    TestTrack::ApplicationIdentity.instance.tap { |i| i.remove_instance_variable(:@identity) if i.instance_variable_defined?(:@identity) }
   end
 end

spec/test_track_spec.rb

@@ -163,6 +163,22 @@
           expect(TestTrack.app_ab(:dummy_feature, context: 'test_context')).to eq false
         end
       end
+
+      context "when called twice" do
+        let(:identity) { TestTrack::ApplicationIdentity.instance }
+
+        before do
+          stub_test_track_assignments(dummy_feature: 'false')
+          allow(identity.send(:identity)).to receive(:test_track_ab).and_call_original
+        end
+
+        it "uses the same instance of the ApplicationIdentity for each call" do
+          TestTrack.app_ab(:dummy_feature, context: 'test_context')
+          TestTrack.app_ab(:dummy_feature, context: 'test_context')
+
+          expect(identity.instance_variable_get(:@identity)).to have_received(:test_track_ab).twice
+        end
+      end
     end
 
     context "when app_name is not specified" do