Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sprockets-rails an optional dependency #147

Merged
merged 1 commit into from
Feb 24, 2025

Conversation

rzane
Copy link
Contributor

@rzane rzane commented Feb 21, 2025

Summary

This gem should not require downstream applications to use sprockets. This gem does provide a JavaScript asset under app/assets/javascript and it does enhance the assets:precompile with additional functionality, but these things don't necessarily depend on sprockets-rails, so it sprockets-rails is really more of an optional dependency.

The dummy app does currently depend on sprockets-rails, so this should be development dependency.

Other Information

If there's anything else that's important and relevant to your pull
request, mention that information here. This could include
benchmarks, or other information.

Thanks for contributing to TestTrack!

/domain @Betterment/test_track_core
/platform @Betterment/test_track_core

Copy link
Member

@samandmoore samandmoore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

domainlgtm platformlgtm

it's a bit of a funky change to release since it's ultimately not an explicit dependency today either, but i think it's a wise change to better communicate the intention.

@rzane rzane merged commit 9c0f9b4 into Betterment:master Feb 24, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants