Make sprockets-rails an optional dependency #147
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This gem should not require downstream applications to use sprockets. This gem does provide a JavaScript asset under
app/assets/javascript
and it does enhance theassets:precompile
with additional functionality, but these things don't necessarily depend onsprockets-rails
, so itsprockets-rails
is really more of an optional dependency.The dummy app does currently depend on
sprockets-rails
, so this should be development dependency.Other Information
/domain @Betterment/test_track_core
/platform @Betterment/test_track_core